Repository navigation
Add Estefania onboarding package - #18
EstefaniaC-M wants to merge 2 commits into
Conversation
|
Hello! Can you try and amend your commit messages to make the CI pass? Also, make sure to fill out the checkboxes in the PR description. I'll take a look at the code soon. Thanks for submitting! |
cole-wilson
left a comment
cole-wilson
left a comment
There was a problem hiding this comment.
code generally looks great, only metadata and logging changes needed!
|
|
||
| add_executable(example_publisher src/example_publisher.cpp) | ||
| add_executable(example_subscriber src/example_subscriber.cpp) | ||
| ament_target_dependencies(example_publisher rclcpp std_msgs) |
There was a problem hiding this comment.
duplicate target. Also, can you rename from example_?
| # estefania_pkg | ||
|
|
||
|
|
||
| explain about your nodes and topics here. No newline at end of file |
There was a problem hiding this comment.
add a brief explanation here
| @@ -0,0 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <launch> | |||
| <node pkg="estefania_pkg" exec="example_publisher"/> | |||
There was a problem hiding this comment.
same here, just change the example_
| <package format="3"> | ||
| <name>estefania_pkg</name> | ||
| <version>0.0.0</version> | ||
| <description>TODO: Package description</description> |
There was a problem hiding this comment.
add name/description/license/email
| std_msgs::msg::Float32 message; | ||
| message.data = distribution_(generator_); | ||
|
|
||
| RCLCPP_INFO(this->get_logger(), "Publishing: %.2f", message.data); |
There was a problem hiding this comment.
remove the log here, just so that the only console output comes from the echo service
| std::string summary = | ||
| "Estefania received the value: " + std::to_string(message->data); | ||
|
|
||
| RCLCPP_INFO(this->get_logger(), "%s", summary.c_str()); |
There was a problem hiding this comment.
same here, standard logs should only come from the echo service
ff9a740 to
43b55aa
Compare
|
I reran the CI job, but it failed again at the cpp-linter step. The log shows 0 clang-format-checks-failed, 0 clang-tidy-checks-failed, and 0 checks-failed. The failure happens when cpp-linter tries to post a comment to PR #18 and GitHub returns a 403 "Resource not accessible by integration" error. |
|
added my onboarding package
Updated the launch files and codeowners