Skip to content

refactor(cli): propagate process cancellation - #118

Merged
pablontiv merged 2 commits into
mainfrom
refactor/process-context
Oct 7, 2026
Merged

pablontiv merged 2 commits into
mainfrom
refactor/process-context

Conversation

@pablontiv

Copy link
Copy Markdown
Owner

Related to #48 — final process phase.

Summary

  • Propagate cancellation through Cobra ExecuteContext and install Interrupt/SIGTERM handling only at the process-owner entry point.
  • Make updater staging waits deterministic when cancellation races completion or timeout.
  • Preserve Picokit’s bounded, non-context-aware fetch as a documented detached residual after caller cancellation.
  • Use nil-safe per-run command/updater dependencies without global composition hooks.
  • Synchronize the subprocess signal test through explicit inherited-pipe readiness.

Validation

  • just ci — passed (85.4% total coverage).
  • go test -race ./cmd/backscroll -count=1 — passed.
  • Windows test-binary compile — passed.
  • Review feedback addressed; equivalent rebase confirmed by range-diff and stable patch IDs.

@pablontiv
pablontiv merged commit ebfdf9d into main Oct 7, 2026
14 checks passed
@pablontiv
pablontiv deleted the refactor/process-context branch October 7, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant