AB#109285 convert to function based app - #94
Merged
Merged
Conversation
Deploying canvas-subaccounts with
|
| Latest commit: |
a8c9e2f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://28df7b81.canvas-subaccounts.pages.dev |
| Branch Preview URL: | https://ab-109285.canvas-subaccounts.pages.dev |
There was a problem hiding this comment.
Pull request overview
This PR modernizes the React codebase by converting several class-based components to function components using Hooks (useState, useEffect, useCallback, useRef) and memoization (React.memo), aligning the app with a function-based component architecture.
Changes:
- Converted
App,AccountsTree,ListAccounts,Account, andErrorfrom class components to function components. - Reworked
AccountsTreedata-loading and search flow to use Hook state/refs and an iterative search approach. - Updated
package-lock.jsonwith dependency metadata changes (removal oflibcentries for some optional packages).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/App.jsx | Converted to Hooks; token handling and derived server config now computed in-function. |
| src/AccountsTree.jsx | Converted to Hooks; rewritten loading/search/open-state logic with refs and functional updates. |
| src/ListAccounts.jsx | Converted to React.memo function component; internal render helpers moved to closures. |
| src/Account.jsx | Converted to function component; click handler now uses useCallback. |
| src/Error.jsx | Converted to a simple function component. |
| package-lock.json | Removes libc metadata from certain optional packages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+96
to
+97
| updateState({ open: { ...state.open, ...toOpen }, from: match }, () => accountRefs.current[match]?.scrollIntoView({ behavior: 'smooth', block: 'center' })) | ||
| } else updateState({ searchMessages: [{ type: 'error', text: state.from ? 'No more matches' : 'No matches' }], from: state.from ? null : state.from }) |
Comment on lines
+36
to
+40
| const servers = settings[window.location.origin] | ||
|
|
||
| updateToken = (token) => { | ||
| const updateToken = useCallback((token) => { | ||
| const jwt = jwtDecode(token) | ||
| this.setState({ | ||
| setState(current => ({ ...current, |
buckett
approved these changes
Sep 17, 2026
buckett
left a comment
buckett
left a comment
Member
There was a problem hiding this comment.
Generally looks ok, although it's hard to reason about.
| const [state, setState] = useState({ search: '', open: {}, tryLoading: true, loadAll: false, loadingAll: false, collections: null }) | ||
| const collectionsRef = useRef(null) | ||
| const accountRefs = useRef([]) | ||
| const updateState = (value, callback) => setState(current => { const next = typeof value === 'function' ? value(current) : value; if (next.collections) collectionsRef.current = next.collections; if (callback) setTimeout(callback, 0); return { ...current, ...next } }) |
Member
There was a problem hiding this comment.
Really hard to read all on one line.
Comment on lines
-211
to
-214
| * We return null to indicate we haven't found anything. | ||
| * An empty array to indicate that the location we were searching from previously has been found | ||
| * A non empty array when we matched | ||
| */ |
| const ordered = [] | ||
| const visit = (id) => { | ||
| ordered.push(id) | ||
| ;(collections[id].collections || []).forEach(visit) |
Member
There was a problem hiding this comment.
What is going on with the formatting here?
lardo-de-arnaud
force-pushed
the
AB#109285
branch
from
September 17, 2026 11:21
af27bf4 to
a8c9e2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.