Conversation
- Add explicit Apache 2.0 attribution header to Lti13InitiatingLoginRequestResolver matching the JHipster pattern used in CachingHttpHeadersFilter. - Qualify ambiguous PR #60 reference as oxctl/spring-security-lti13#60 with full upstream URL in CustomLti13Configurer Javadoc.
|
Thanks for working on this. I've tested this on a Spring Boot 4.0 based project and ran into an compatibility issue with Hibernate 7. Spring Framework 7.0 upgraded to Jakarta EE 11 API level (Servlet 6.1, JPA 3.2, Bean Validation 3.1). But the library currently depends on Jakarta EE 10.
Furthermore, Spring Framework 7.0 deprecated Jackson 2.x support and will remove auto detection in 7.1 and support in 7.2 (see https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-7.0-Release-Notes#jackson-3x-support). So I think it would be best to switch now as part of this PR to avoid new compatibility issues in the near future. |
|
@buckett @henriknik any updates on this? @dgerhardt brings up some valid points about the dependencies that I think need to be fixed. I'm part of a development team at UVA, one of the tasks we would like to complete in the near future is getting our LTI tools onto Spring 7, if I can help in anyway to get this work across the finish line please let me know, thanks! |
Spring Framework 7 moved to the Jakarta EE 11 API level and deprecated Jackson 2.x support.
|
Thanks for the updates! We added these changes to some of our LTI tools in Canvas at UVA and things are looking good so far! We will keep taking a look at it this week as it runs in our dev environment and I'll let yall know if we have any issues. |
|
@mitch30000 any updates? |
|
@lardo-de-arnaud so far so good! It has been running in our dev instance for some time now and we haven't seen any issues. We haven't pushed it to prod yet because there are some other features/bugs we are working on for the tools as part of the overall Spring 7 upgrade, but I'm not expecting any problems with this change once we do move it to prod. |
Migrates the library to Spring Framework 7 / Spring Security 7. This is a breaking change.