Do not restrict merge types by default#105
Conversation
The changes in osac-project#98 restricted regular merges and squash merges. This has caused problems with CI because tide is attempting to create merge commits. This change sets the default value for alllow_merge_commit and allow_squash_merge to `true` pending further discussion.
|
Caution Review failedPull request was closed or merged during review WalkthroughTwo Terraform variable defaults in ChangesRepository Merge Strategy Defaults
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
The changes in #98 restricted regular merges and squash merges. This has
caused problems with CI because tide is attempting to create merge commits.
This change sets the default value for alllow_merge_commit and
allow_squash_merge to
truepending further discussion.Summary by CodeRabbit