Repository navigation
Support portable Windows style generation - #48
Merged
Merged
Conversation
biodranik
force-pushed
the
ab/designer-windows
branch
from
October 6, 2026 21:30
19f4938 to
d4beca5
Compare
biodranik
changed the title
Use an explicit fork context to share parsed style globals where available, and evaluate serially on platforms such as Windows that lack fork. Avoid changing the interpreter's process-wide start method. Read and write compiler text as UTF-8 so MapCSS imports and data files do not depend on the Windows system code page. Cover a legacy encoding default. Signed-off-by: Alexander Borsuk <me@alex.bio>
biodranik
force-pushed
the
ab/designer-windows
branch
from
October 7, 2026 07:20
d4beca5 to
570e62f
Compare
Member
Author
|
What were the reasons to keep kothic on Python 3.9, not on 3.12? Maybe make a separate PR that will upgrade it? |
strump
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows has no
forkstart method, so default style compilation fails. Use an explicit fork context where available and serial evaluation otherwise, without changing the interpreter's global start method.The parent production-style test also exposed CP1252 decoding of UTF-8 MapCSS imports. Read/write compiler text explicitly as UTF-8; a regression simulates a legacy default encoding and checks imported Unicode values.
The real compiler tests use temporary fixtures, compare spawn-only output with the default path, and run on Linux/Windows with Python 3.9 and 3.14. All 60 tests and Ruff pass locally. The parent's full default-family generation also passes locally.
Fixes Windows portability issues reported in organicmaps/organicmaps#12699.