[GR-75099] Hide C API helpers.#889
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change reduces the GraalPy-specific ABI surface. In particular, we exported all our internal helper/upcall functions and variables.
The new policy for a symbol being exported is:
GraalPyFloat_AS_DOUBLE), orGraalPy_CAPI_HELPERS,GraalPy_CAPI_METADATA, andinitialize_graal_capi.Everything else should be hidden or local.
Major changes summary:
graalpy/testcapi.hwhich defines a struct with the necessary members. The instance of this struct is then exposed via a capsule. This is the Python way to do it.GraalPy_CAPI_HELPERS) that is generated fromNativeCAPISymbol. In that case, it doesn't matter if the symbol is exported or hidden.GraalPy_CAPI_HELPER_SYMBOLto mark such helper functions. The macro is just an alias forPy_LOCAL_SYMBOL.CFieldsandCStructs) into table, i.e.,GraalPy_CAPI_METADATA.abi/abi-graalpy250.xmlandabi/suppressions-base.ini.We do no longer suppress
GraalPyPrivate-prefixed symbols.