Add FRR BGP Confederation Options/Fields#5569
Open
Napsterbater wants to merge 4 commits into
Open
Conversation
Add bgp.confed_asn and bgp.confed_peers fields.
Added field definitions, validation to BGP.xml and modified BGP.php to validate that both fields are mutually required, and present error if not.
Added FRR BGP Confederation to config file generation.
Fix minor formatting issue, 1 Tab missing on line 14.
Member
|
We recently added this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Describe the problem
Unable to use FRR in OPNsense with in a BGP Confederations without these options.
Describe the proposed solution
Add 2 fields and relevant validation and config generation to add the two config lines to the FRR service.
Related issue
#2202
I have already made these changes locally, and from my limited testing it works as intended.
The BGP.php was the trickiest, and not sure if that was the best or only way to deal with that.
One other minor thing I noticed with this, when using the Copy then Paste buttons on the Confederation Peers, it's only copying the first. Not sure how to fix that, assuming minor change.