Skip to content

test: cover migration acknowledgments and enforce dry-run eligibility - #56

Open
tmshort wants to merge 1 commit into
mainfrom
migration-acknowledgment-e2e-tests
Open

tmshort wants to merge 1 commit into
mainfrom
migration-acknowledgment-e2e-tests

Conversation

@tmshort

@tmshort tmshort commented Oct 1, 2026

Copy link
Copy Markdown
Member

Summary

Add fixture E2E coverage for seven soft compatibility checks and five non-overridable hard blocks. Each soft case verifies refusal without its acknowledgment, a non-mutating acknowledged dry-run, and successful conversion with the audit annotation. Each hard case verifies that acknowledgments cannot bypass the rejection.

Fix single-operator dry-run so it performs the same readiness, compatibility, and catalog checks as conversion. Add unit coverage for that behavior. The new migration/test-e2e-acknowledgments target runs the isolated fixture scenarios with coverage in CI. Update the migration E2E guide and test plan.

Validation

  • make migration/test-unit
  • go test -tags=e2e ./test/e2e/migration -run '^$'
  • make migration/test-e2e-acknowledgments (all 12 scenarios passed before the branch was rebased; the rebase preserved the patch)

Tracks OPRUN-4762.

@openshift-ci

openshift-ci Bot commented Oct 1, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelanford for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 37 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 527451f7-5f9f-46ca-91af-d7c54a2d9bba

📥 Commits

Reviewing files that changed from the base of the PR and between 83e4e91 and b779602.

📒 Files selected for processing (7)
  • .github/workflows/migration-test.yaml
  • migration.mk
  • migration/examples/cmd/migrate-operators-v0-to-v1/convert.go
  • migration/examples/cmd/migrate-operators-v0-to-v1/dryrun_eligibility_test.go
  • specs/20260821-migration-v0-to-v1/e2e.md
  • specs/20260821-migration-v0-to-v1/test-plan.md
  • test/e2e/migration/acknowledgment_test.go
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tmshort
tmshort force-pushed the migration-acknowledgment-e2e-tests branch from 6dfe552 to f2990ed Compare October 1, 2026 19:19
Signed-off-by: Todd Short <tshort@redhat.com>
@tmshort
tmshort force-pushed the migration-acknowledgment-e2e-tests branch from f2990ed to b779602 Compare October 1, 2026 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant