Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
6dfe552 to
f2990ed
Compare
Signed-off-by: Todd Short <tshort@redhat.com>
f2990ed to
b779602
Compare
Summary
Add fixture E2E coverage for seven soft compatibility checks and five non-overridable hard blocks. Each soft case verifies refusal without its acknowledgment, a non-mutating acknowledged dry-run, and successful conversion with the audit annotation. Each hard case verifies that acknowledgments cannot bypass the rejection.
Fix single-operator dry-run so it performs the same readiness, compatibility, and catalog checks as conversion. Add unit coverage for that behavior. The new
migration/test-e2e-acknowledgmentstarget runs the isolated fixture scenarios with coverage in CI. Update the migration E2E guide and test plan.Validation
make migration/test-unitgo test -tags=e2e ./test/e2e/migration -run '^$'make migration/test-e2e-acknowledgments(all 12 scenarios passed before the branch was rebased; the rebase preserved the patch)Tracks OPRUN-4762.