Skip to content

Allows invoker tests to work with verify instead of install #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
codefromthecrypt merged 1 commit into from
Mar 24, 2026
+14 −4
Merged

Allows invoker tests to work with verify instead of install #1471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions build-bin/test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
#
# See [README.md] for an explanation of this and how CI should use it.

# We use install, not verify, because maven-invoker-tests need brave-tests
# installed into the local repository before it can run.
#
# We avoid -T1C because some plugins don't work in parallel and also ITs are
# difficult to debug when failures are in parallel.
./mvnw install -nsu "$@"
./mvnw verify -nsu "$@"
3 changes: 3 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,9 @@
<maven-help-plugin.version>3.5.1</maven-help-plugin.version>
<maven-install-plugin.version>3.1.4</maven-install-plugin.version>
<maven-invoker-plugin.version>3.9.1</maven-invoker-plugin.version>
<!-- default is runtime, but test-scoped reactor deps like brave-tests
need to be in the invoker local repo for IT projects to resolve -->
<invoker.install.scope>test</invoker.install.scope>
<maven-javadoc-plugin.version>3.12.0</maven-javadoc-plugin.version>
<maven-jar-plugin.version>3.5.0</maven-jar-plugin.version>
<maven-release-plugin.version>3.3.1</maven-release-plugin.version>
Expand Down
6 changes: 6 additions & 0 deletions spring-beans/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@
<version>${project.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>brave-tests</artifactId>
<version>${project.version}</version>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand Down
4 changes: 4 additions & 0 deletions src/it/settings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,11 @@
<url>@localRepositoryUrl@</url>
<releases>
<enabled>true</enabled>
<updatePolicy>always</updatePolicy>
</releases>
<snapshots>
<enabled>true</enabled>
<updatePolicy>always</updatePolicy>
</snapshots>
</repository>
</repositories>
Expand All @@ -30,9 +32,11 @@
<url>@localRepositoryUrl@</url>
<releases>
<enabled>true</enabled>
<updatePolicy>always</updatePolicy>
</releases>
<snapshots>
<enabled>true</enabled>
<updatePolicy>always</updatePolicy>
</snapshots>
</pluginRepository>
</pluginRepositories>
Expand Down
Loading