Repository navigation
Conversation
github-actions
Bot
added
the
category: OpenVINO Notes
allnes
requested changes
Oct 12, 2026
allnes
left a comment
allnes
left a comment
Contributor
There was a problem hiding this comment.
The shared cloud fixture still accepts chunks for completed and expired sessions. A completed-session retry can issue another write and overwrite a later object revision. Please enforce the session state before mutating the buffer or object and add regression tests for completion retries and expiry.
N1smi
marked this pull request as draft
October 12, 2026 19:55
N1smi
force-pushed
the
resumable-states
branch
from
October 24, 2026 13:24
8eb08cb to
86dd095
Compare
# Conflicts: # modules/openvino-notes/cloud/api/src/main/kotlin/com/openvino/notes/cloud/api/CloudApi.kt
- verify completed session retries preserve remote revision and later updates - verify expired sessions cannot publish objects or commit chunks
N1smi
force-pushed
the
resumable-states
branch
from
October 24, 2026 13:51
86dd095 to
c102853
Compare
N1smi
marked this pull request as ready for review
October 24, 2026 13:54
allnes
approved these changes
Oct 28, 2026
Contributor
|
please resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
Active,Completed, andExpiredstates for resumable file transfers.Changes
CloudApi.kt: AddedResumableUploadStatesealed interface withActive,Completed, andExpiredstates.FakeRemoteStore.kt: Added support for session states and expiration handling.ResumableTransferContractTest.kt: Added contract tests for the new states.DriveCloudComponent.kt: Updated stubs to match the new states.