Skip to content

WIP: enhance ACP Chat queued messages and agentic workflow#4763

Open
lulusir wants to merge 21 commits into
mainfrom
codex/optimize-acpchat-experience
Open

WIP: enhance ACP Chat queued messages and agentic workflow#4763
lulusir wants to merge 21 commits into
mainfrom
codex/optimize-acpchat-experience

Conversation

@lulusir

@lulusir lulusir commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Types

  • 🎉 New Features
  • 💄 Style Changes
  • ⏱ Tests

Background or solution

This PR improves the ACP Chat experience with queued follow-up messages and agentic workflow refinements.

When ACP Chat is generating a response, users can continue sending follow-up prompts. These messages are queued and automatically sent in FIFO order after the current turn completes. The queue UI supports expand/collapse, edit, delete, send next, and clear all actions.

This PR also improves the agentic chat layout by adding a dedicated panel header, workbench maximize/collapse controls, and menu bar integration for toggling the agentic workbench. File paths rendered in chat messages can now be opened directly in the editor, with the workbench restored and the file revealed in the explorer when possible.

Changelog

  • Add queued message support for ACP Chat while a response is generating.
  • Add queued message UI with edit, delete, send next, and clear all actions.
  • Keep ACP input usable during loading so users can compose follow-up messages.
  • Add agentic chat panel header and maximize/collapse action.
  • Add agentic workbench visibility commands and layout service state.
  • Wire the top menu bar toggle to agentic workbench visibility when available.
  • Make chat-rendered file paths clickable and open them in the editor with range support.
  • Improve generic tool call rendering for non-MCP tools.
  • Add ACP agentic BDD scenarios and Playwright coverage.
  • Add focused Jest coverage for queued messages, file links, panel layout, menu bar, and chat rendering.

@opensumi opensumi Bot added the 🎨 feature feature required label Jul 3, 2026
@lulusir lulusir changed the title feat: enhance ACP Chat queued messages and agentic workflow WIP: enhance ACP Chat queued messages and agentic workflow Jul 3, 2026
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The head commit changed during the review from 2940da3 to 0edf1eb.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/optimize-acpchat-experience

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.40810% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.81%. Comparing base (a07b4ee) to head (58a3159).

Files with missing lines Patch % Lines
...kages/ai-native/src/browser/chat/acp-chat-agent.ts 6.25% 14 Missing and 1 partial ⚠️
...ges/ai-native/src/node/acp/acp-cli-back.service.ts 90.62% 5 Missing and 1 partial ⚠️
...ative/src/browser/chat/acp-chat-queued-messages.ts 88.23% 4 Missing ⚠️
.../browser/acp/permission-title-indicator.service.ts 95.45% 2 Missing ⚠️
...browser/layout/agentic-workbench-command-reveal.ts 93.10% 2 Missing ⚠️
...tive/src/browser/acp/acp-permission-rpc.service.ts 0.00% 1 Missing ⚠️
packages/ai-native/src/browser/acp/index.ts 0.00% 1 Missing ⚠️
packages/ai-native/src/browser/chat/chat-model.ts 92.85% 1 Missing ⚠️
...s/ai-native/src/browser/chat/pick-workspace-dir.ts 94.44% 1 Missing ⚠️
...ai-native/src/node/acp/acp-agent-update-adapter.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4763      +/-   ##
==========================================
+ Coverage   53.57%   53.81%   +0.23%     
==========================================
  Files        1753     1756       +3     
  Lines      111926   112220     +294     
  Branches    24817    24890      +73     
==========================================
+ Hits        59966    60388     +422     
+ Misses      43136    43022     -114     
+ Partials     8824     8810      -14     
Flag Coverage Δ
jsdom 47.25% <67.28%> (+0.19%) ⬆️
node 13.76% <22.42%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lulusir

lulusir commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

/next

@lulusir

lulusir commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

/next

@opensumi

opensumi Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

🎉 PR Next publish successful!

3.9.1-next-1783327199.0

@lulusir

lulusir commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/next

@opensumi

opensumi Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🎉 PR Next publish successful!

3.9.1-next-1783410798.0

@lulusir

lulusir commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

/next

@opensumi

opensumi Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

🎉 PR Next publish successful!

3.9.1-next-1783436180.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎨 feature feature required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant