[release-4.22] OCPBUGS-112554: Use Add() instead of AddRateLimited() for routine Profile enqueues - #1601
Conversation
Change 1: workqueue.DefaultTypedControllerRateLimiter's AddRateLimited() draws from a single 10qps/burst-100 token bucket shared by every item in the queue, regardless of kind or key. Cascade/trigger enqueues (Pod/Node change to Profile update, per-Profile bootstrap loop, initial bootstrap event) used AddRateLimited() for ordinary enqueuing rather than error retries. During a burst of ~100 nodes joining, this exhausted the shared bucket, delaying later Profile syncs by minutes even though they were never dropped, just queued behind the backlog. Switch these call sites to Add(), which is unthrottled and still deduped by key via the delaying queue's dirty set. Keep AddRateLimited() only for its intended purpose: the retry-after- sync()-error path, where per-key exponential backoff is correct. Change 2: validateTunedCRs() called UpdateStatus() on every Tuned CR on every invocation, even when the computed status conditions were identical to what's already stored. Compare the newly computed status against the cached copy with reflect.DeepEqual() and skip the UpdateStatus() call when nothing semantically changed. Resolves: OCPBUGS-105458
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-112279 has been cloned as Jira Issue OCPBUGS-112554. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-112554, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-bug
|
/lgtm |
|
Scheduling required tests: |
|
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
@jmencak: Only users can be targets for the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
backport-risk-assessed
|
/verified later @shyadav10 |
openshift-ci-robot
added
verified-later
verified
|
@jmencak: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jmencak, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
a3edd3e
into
openshift:release-4.22
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-112554: All pull requests linked via external trackers have merged: This pull request has the DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherry-pick release-4.21 |
|
@jmencak: new pull request created: #1616 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3 participants
This is an automated cherry-pick of #1595
/assign jmencak