Register libvirt-s390x-vpn-ssp cluster profile

[Davo911]

Add a new cluster profile libvirt-s390x-vpn-ssp for running SSP e2e functional tests on s390x architecture in the orange zone VPN environment

This provides a dedicated profile for the SSP operator CI lane, using its own host and Boskos leases, will be added in a follow-up PR
Signed-off-by: Thomas-David Griedel griedel911@gmail.com

Summary

This pull request extends the OpenShift CI tools cluster profile API to add a new s390x “orange zone” VPN libvirt cluster profile for SSP e2e functional testing. It introduces the libvirt-s390x-vpn-virt profile so CI jobs and infrastructure resolution can consistently derive the expected cluster type and Boskos quota-slice lease name for this SSP-focused lane.

Changes

pkg/api/clusterprofile.go

• Added a new exported ClusterProfile constant:
  • ClusterProfileLibvirtS390xVPNVirt ClusterProfile = "libvirt-s390x-vpn-virt"
• Registered the new profile in ClusterProfiles() so it’s accepted as a valid input.
• Updated the conversion helpers to support this profile end-to-end:
  • ClusterType() now maps ClusterProfileLibvirtS390xVPNVirt → "libvirt-s390x-vpn-virt".
  • LeaseType() now maps ClusterProfileLibvirtS390xVPNVirt → "libvirt-s390x-vpn-virt-quota-slice".
  • LeaseTypeFromClusterType() now accepts "libvirt-s390x-vpn-virt" and converts it to the corresponding -quota-slice lease type.

Impact

CI configuration can reference libvirt-s390x-vpn-virt to ensure SSP e2e jobs resolve the correct cluster type and Boskos lease/quota-slice naming for the orange zone VPN environment (with host and Boskos lease resource details planned in a follow-up).

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f67140f9-9639-4abc-92d5-9d046c7b5d5b

📥 Commits

Reviewing files that changed from the base of the PR and between 4d5370d and cb1afec.

📒 Files selected for processing (1)

• pkg/api/clusterprofile.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• openshift/release (manual)
• openshift/ci-docs (manual)
• openshift/release-controller (manual)
• openshift/ci-chat-bot (manual)

---

📝 Walkthrough

Walkthrough

Adds a new ClusterProfileLibvirtS390xVPNVirt constant ("libvirt-s390x-vpn-virt") to pkg/api/clusterprofile.go and registers it in all four profile mapping functions: ClusterProfiles(), ClusterType(), LeaseType(), and LeaseTypeFromClusterType().

Changes

New libvirt-s390x-vpn-virt cluster profile

Layer / File(s)	Summary
Constant definition and mapping wiring pkg/api/clusterprofile.go	Declares ClusterProfileLibvirtS390xVPNVirt = "libvirt-s390x-vpn-virt", includes it in the profiles list, maps it to cluster type "libvirt-s390x-vpn-virt" in ClusterType(), maps it to lease type "libvirt-s390x-vpn-virt-quota-slice" in LeaseType(), and registers the reverse lookup in LeaseTypeFromClusterType().

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions 'libvirt-s390x-vpn-ssp' but the code change adds 'libvirt-s390x-vpn-virt' constant—these are different profile names.	Update the title to match the actual constant being registered, e.g., 'Register libvirt-s390x-vpn-virt cluster profile', or verify the constant name matches the intended profile.
Test Coverage For New Features	⚠️ Warning	New file pkg/api/clusterprofile.go (1346 lines) adds multiple public functions with complex switch-based mappings (ClusterType, LeaseType, LeaseTypeFromClusterType, etc.) but no corresponding unit...	Add a clusterprofile_test.go file with comprehensive unit tests for conversion functions, including table-driven tests validating all cluster profiles are mapped correctly in ClusterType(), LeaseType(), and LeaseTypeFromClusterType() fun...

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Go Error Handling	✅ Passed	The PR adds a cluster profile constant and integrates it into switch statements. No error handling violations found: no ignored errors, no panic calls, proper nil checks before dereferences, and co...
Stable And Deterministic Test Names	✅ Passed	PR modifies only pkg/api/clusterprofile.go, a regular package file with no Ginkgo test code. Check is not applicable to non-test files.
Test Structure And Quality	✅ Passed	This PR adds a cluster profile constant definition only; contains no Ginkgo test code. The check does not apply.
Microshift Test Compatibility	✅ Passed	This PR does not add any new Ginkgo e2e tests. It only adds a cluster profile constant and updates related API mappings in pkg/api/clusterprofile.go. The custom check for MicroShift test compatibil...
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR adds only a new cluster profile constant and helper functions to clusterprofile.go; it does not add any Ginkgo e2e tests (It(), Describe(), Context(), etc.). The check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only adds cluster profile configuration constants with no deployment manifests, operator code, or scheduling constraints. Topology-aware scheduling check is not applicable to pure configuration...
Ote Binary Stdout Contract	✅ Passed	File is a library package (pkg/api) with no process-level code or stdout writes. Changes only add a constant and update switch cases with no side effects.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR adds only cluster profile constants to pkg/api/clusterprofile.go. No Ginkgo e2e tests (It(), Describe(), Context(), etc.) are added, making the IPv6/disconnected network test check not applicable.
No-Weak-Crypto	✅ Passed	The PR only adds a new cluster profile constant and corresponding mappings in switch statements. No weak cryptographic algorithms, custom crypto implementations, or unsafe token/secret comparisons...
Container-Privileges	✅ Passed	PR only adds a Go cluster profile constant definition with no Kubernetes/container manifests; container-privileges check is inapplicable to this change.
No-Sensitive-Data-In-Logs	✅ Passed	No logging or sensitive data exposure found. All changes are constant definitions and case statements for a cluster profile identifier containing only non-sensitive infrastructure information.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Davo911
Once this PR has been reviewed and has the lgtm label, please assign deepsm007 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

Hi @Davo911. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[nestoracunablanco]

Thanks for the PR, @Davo911. Some comments only regarding naming convention.

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e

[openshift-ci]

@Davo911: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e	cb1afec	link	true	/test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.