[anwesha-palit-redhat]

Type of Change

• Bug fix
• New feature
• Refactoring
• Migration
• CVE Fix

Summary

Screen Recordings / Screenshot

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [anwesha-palit-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[qodo-code-review]

PR Reviewer Guide 🔍

Warning

/review is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 PR contains tests

🔒 Security concerns Unpinned remote manifest: setup-approval-task.sh passes a URL on a mutable upstream branch directly to oc apply. A changed or compromised manifest could be applied with the script user's cluster privileges; pin and review its contents.

⚡ Recommended focus areas for review Unpinned Manifest The script applies a manifest from the mutable main branch with the caller's oc permissions. Pin it to a reviewed commit or checked-in file so later upstream changes cannot alter what this script applies. MANUAL_APPROVAL_GATE_CR_URL="https://raw.githubusercontent.com/tektoncd/operator/refs/heads/main/config/crs/openshift/manualapprovalgate/operator_v1alpha1_manualapprovalgate_cr.yaml" echo "[INFO] Applying ManualApprovalGate CR..." oc apply -f "$MANUAL_APPROVAL_GATE_CR_URL" False Match When a PipelineRun has no UID, comparing its missing UID with a Workload's missing job-uid label can produce a false cluster match. Require a PipelineRun UID before applying this match. if (selectedCluster && workloadsLoaded) { const plrUid = (obj as unknown as PipelineRunKind).metadata?.uid; const spokeCluster = workloads?.find( (w) => w.metadata?.labels?.[WORKLOAD_KUEUE_UID_LABEL] === plrUid, )?.status?.clusterName; if (spokeCluster !== selectedCluster) return false; Sorting Cost Each sort comparison searches the entire Workload list for both PipelineRuns. Consider building a UID-to-cluster lookup once; large lists could otherwise make sorting noticeably slow. sort: (data: PipelineRunKind[], direction: SortByDirection) => [...data].sort((a, b) => { const aCluster = getClusterNameForPipelineRun( a, workloads ?? [], ); const bCluster = getClusterNameForPipelineRun( b, workloads ?? [], ); const comparison = aCluster.localeCompare(bCluster);

[qodo-code-review]

Important

The /generate_labels command by Qodo was deprecated on the 1st of October 2026 and is no longer available. We recommend switching to the latest Qodo review capabilities. Learn more