Skip to content

SRVKP-15402: update PF module in package.json [release-v1.23.x] - #1465

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-pipelines:release-v1.23.xfrom
openshift-cherrypick-robot:cherry-pick-1463-to-release-v1.23.x
Nov 4, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift-pipelines:release-v1.23.xfrom
openshift-cherrypick-robot:cherry-pick-1463-to-release-v1.23.x

Conversation

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #1463

/assign anwesha-palit-redhat

@openshift-ci-robot

openshift-ci-robot commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: SRVKP-15402

Details

In response to this:

This is an automated cherry-pick of #1463

/assign anwesha-palit-redhat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@qodo-code-review

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Warning

/review is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Lockfile Mismatch

The @patternfly/react-styles version range changes without a corresponding yarn.lock update. Verify that frozen installs succeed and that the resolved version is the one intended.

"@patternfly/react-styles": "^6.4.0",
"@patternfly/react-table": "^6.4.0",
Missing Dependency

A missing PatternFly package is reported as SKIP, even when it is a direct dependency. This lets the check succeed if a required resolution is absent from yarn.lock.

for (const pkg of PKGS_TO_CHECK) {
  const versions = patternflyModules.get(pkg.name) || [];
  if (versions.length === 0) {
    console.log(`  SKIP  ${pkg.name} — not in yarn.lock`);
Unused Check

The PR adds the checker but does not wire it into a package script or CI step. Confirm it will run where lockfile changes are validated.

console.log('Checking yarn.lock for PatternFly module resolutions...');

@qodo-code-review

Copy link
Copy Markdown

Important

The /generate_labels command by Qodo was deprecated on the 1st of October 2026 and is no longer available. We recommend switching to the latest Qodo review capabilities. Learn more

@anwesha-palit-redhat
anwesha-palit-redhat removed the request for review from vdemeester November 4, 2026 08:31
@anwesha-palit-redhat anwesha-palit-redhat changed the title [release-v1.23.x] SRVKP-15402: update PF module in package.json SRVKP-15402: update PF module in package.json [release-v1.23.x] Nov 4, 2026

@anwesha-palit-redhat anwesha-palit-redhat left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Looks Good to Me Label label Nov 4, 2026
@openshift-ci

openshift-ci Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Label for Approved PRs label Nov 4, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit a55d906 into openshift-pipelines:release-v1.23.x Nov 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Label for Approved PRs jira/valid-reference lgtm Looks Good to Me Label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants