Skip to content

chore(deps): update dependency @patternfly/react-icons to v6.6.1 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
red-hat-konflux wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): update dependency @patternfly/react-icons to v6.6.1 #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/gateway-management-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
},
"peerDependencies": {
"@patternfly/react-core": "6.6.0",
"@patternfly/react-icons": "6.6.0",
"@patternfly/react-icons": "6.6.1",

@jsell-rh jsell-rh Aug 27, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bumps the peer dependency to 6.6.1, but the devDependencies entry for @patternfly/react-icons (line 37, unchanged) is still 6.6.0, and pnpm-lock.yaml resolves it to 6.6.0. The package therefore declares consumers must supply 6.6.1 while it is itself built and tested against 6.6.0. Bump the dev entry to 6.6.1 and regenerate the lockfile in this PR so peer/dev/lock all agree. (No --frozen-lockfile break expected, since pnpm does not track peerDependencies specifiers in the lockfile.)

@jsell-rh jsell-rh Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Minor] Peer/dev version drift. This bumps the peerDependencies pin to 6.6.1, but devDependencies (L37) and the lockfile still resolve @patternfly/react-icons@6.6.0. With exact pins, the package now declares a peer requirement for a version it never builds/tests against, and it diverges from the sibling PatternFly peers (react-core, react-table still 6.6.0). Please bump the devDependencies entry to 6.6.1 too (and regenerate pnpm-lock.yaml) to keep them consistent. Patch bump, so low functional risk.

"@patternfly/react-table": "6.6.0",
"@tanstack/react-query": "5.101.4",
"react": "19.2.8",
Expand Down
Loading