-
Notifications
You must be signed in to change notification settings - Fork 10
fix(auth): enforce management API JWT audience #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
65d0e74
3c99f17
fa78645
f6070b3
0fe5478
63f2686
bb0c9d8
45b091c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ require ( | |
| github.com/golang/glog v1.2.5 | ||
| github.com/gorilla/mux v1.7.3 | ||
| github.com/onsi/gomega v1.27.1 | ||
| github.com/openshift-online/rh-trex-ai v0.0.32-0.20260819203335-5798cb607fcb | ||
| github.com/openshift-online/rh-trex-ai v0.0.32-0.20260821210346-d5888edfb8cd | ||
| github.com/prometheus/client_golang v1.16.0 | ||
| github.com/segmentio/ksuid v1.0.2 | ||
| github.com/spf13/cobra v0.0.5 | ||
|
|
@@ -37,11 +37,23 @@ require ( | |
| github.com/Masterminds/squirrel v1.1.0 // indirect | ||
| github.com/Microsoft/go-winio v0.6.2 // indirect | ||
| github.com/antlr/antlr4 v0.0.0-20190518164840-edae2a1c9b4b // indirect | ||
| github.com/atotto/clipboard v0.1.4 // indirect | ||
| github.com/aymanbagabas/go-osc52/v2 v2.0.1 // indirect | ||
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/bxcodec/faker/v3 v3.2.0 // indirect | ||
| github.com/cenkalti/backoff/v4 v4.2.1 // indirect | ||
| github.com/cenkalti/backoff/v5 v5.0.3 // indirect | ||
| github.com/cespare/xxhash/v2 v2.3.0 // indirect | ||
| github.com/charmbracelet/bubbles v1.0.0 // indirect | ||
| github.com/charmbracelet/bubbletea v1.3.10 // indirect | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [Minor] Unexpected dependency expansion from the auth bump. The rh-trex-ai upgrade transitively adds a full terminal-UI stack ( Please confirm this transitive pull is intended, and verify the new modules satisfy the dependency-age policy: only |
||
| github.com/charmbracelet/colorprofile v0.4.1 // indirect | ||
| github.com/charmbracelet/lipgloss v1.1.1-0.20250404203927-76690c660834 // indirect | ||
| github.com/charmbracelet/x/ansi v0.11.6 // indirect | ||
| github.com/charmbracelet/x/cellbuf v0.0.15 // indirect | ||
| github.com/charmbracelet/x/term v0.2.2 // indirect | ||
| github.com/clipperhouse/displaywidth v0.9.0 // indirect | ||
| github.com/clipperhouse/stringish v0.1.1 // indirect | ||
| github.com/clipperhouse/uax29/v2 v2.5.0 // indirect | ||
| github.com/containerd/errdefs v1.0.0 // indirect | ||
| github.com/containerd/errdefs/pkg v0.3.0 // indirect | ||
| github.com/containerd/log v0.1.0 // indirect | ||
|
|
@@ -53,6 +65,7 @@ require ( | |
| github.com/docker/go-connections v0.6.0 // indirect | ||
| github.com/docker/go-healthcheck v0.1.0 // indirect | ||
| github.com/docker/go-units v0.5.0 // indirect | ||
| github.com/erikgeiser/coninput v0.0.0-20211004153227-1c3628e74d0f // indirect | ||
| github.com/felixge/httpsnoop v1.0.4 // indirect | ||
| github.com/ghodss/yaml v1.0.0 // indirect | ||
| github.com/go-logr/logr v1.4.3 // indirect | ||
|
|
@@ -74,8 +87,12 @@ require ( | |
| github.com/lann/builder v0.0.0-20180802200727-47ae307949d0 // indirect | ||
| github.com/lann/ps v0.0.0-20150810152359-62de8c46ede0 // indirect | ||
| github.com/lib/pq v1.10.9 // indirect | ||
| github.com/lucasb-eyer/go-colorful v1.3.0 // indirect | ||
| github.com/lufia/plan9stats v0.0.0-20211012122336-39d0f177ccd0 // indirect | ||
| github.com/magiconair/properties v1.8.10 // indirect | ||
| github.com/mattn/go-isatty v0.0.20 // indirect | ||
| github.com/mattn/go-localereader v0.0.1 // indirect | ||
| github.com/mattn/go-runewidth v0.0.19 // indirect | ||
| github.com/matttproud/golang_protobuf_extensions v1.0.4 // indirect | ||
| github.com/mendsley/gojwk v0.0.0-20141217222730-4d5ec6e58103 // indirect | ||
| github.com/moby/docker-image-spec v1.3.1 // indirect | ||
|
|
@@ -86,13 +103,17 @@ require ( | |
| github.com/moby/sys/userns v0.1.0 // indirect | ||
| github.com/moby/term v0.5.0 // indirect | ||
| github.com/morikuni/aec v1.0.0 // indirect | ||
| github.com/muesli/ansi v0.0.0-20230316100256-276c6243b2f6 // indirect | ||
| github.com/muesli/cancelreader v0.2.2 // indirect | ||
| github.com/muesli/termenv v0.16.0 // indirect | ||
| github.com/opencontainers/go-digest v1.0.0 // indirect | ||
| github.com/opencontainers/image-spec v1.1.1 // indirect | ||
| github.com/pkg/errors v0.9.1 // indirect | ||
| github.com/power-devops/perfstat v0.0.0-20210106213030-5aafc221ea8c // indirect | ||
| github.com/prometheus/client_model v0.3.0 // indirect | ||
| github.com/prometheus/common v0.42.0 // indirect | ||
| github.com/prometheus/procfs v0.10.1 // indirect | ||
| github.com/rivo/uniseg v0.4.7 // indirect | ||
| github.com/shirou/gopsutil/v3 v3.23.12 // indirect | ||
| github.com/shoenig/go-m1cpu v0.1.6 // indirect | ||
| github.com/sirupsen/logrus v1.9.3 // indirect | ||
|
|
@@ -101,6 +122,7 @@ require ( | |
| github.com/tklauser/go-sysconf v0.3.12 // indirect | ||
| github.com/tklauser/numcpus v0.6.1 // indirect | ||
| github.com/uptrace/opentelemetry-go-extra/otelsql v0.3.2 // indirect | ||
| github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect | ||
| github.com/yusufpapurcu/wmi v1.2.4 // indirect | ||
| go.opentelemetry.io/auto/sdk v1.2.1 // indirect | ||
| go.opentelemetry.io/otel/exporters/otlp/otlptrace v1.44.0 // indirect | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Minor] Dependency footprint (informational). The
rh-trex-aibump pulls in a large set of Charmbracelet/TUI indirect deps (bubbletea,lipgloss,bubbles,termenv, etc.) unrelated to JWT validation. Inherited from upstream, not caused by this PR, but worth confirming these are intended and that the new recent transitive modules don't trip the dependency-age policy (the allowlist only pinsrh-trex-aidirectly).