Skip to content

chore(deps): update docker.io/library/postgres docker tag to v18 #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
red-hat-konflux-kflux-prd-rh02 wants to merge 1 commit into from
Closed

chore(deps): update docker.io/library/postgres docker tag to v18 #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ database:
# -- Deploy a single-pod PostgreSQL instance
enabled: true
# -- PostgreSQL container image
image: docker.io/library/postgres:14.2
image: docker.io/library/postgres:18.4

@coderabbitai coderabbitai Bot Jun 22, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | 🏗️ Heavy lift

PostgreSQL 14→18 upgrade requires data migration; existing deployments will fail.

This jumps four major versions. PostgreSQL data directories are NOT forward-compatible across major versions. Existing StatefulSets that restart with this image will crash with binary incompatibility errors (CWE-665: Improper Initialization). Production impact: data inaccessible, service down.

Required before merge:

  • Add migration instructions to NOTES.txt or values.yaml comments
  • Consider gating this behind a new flag (e.g., postgresql.version) with validation
  • Document pg_upgrade or dump/restore steps for existing installations
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@charts/values.yaml` at line 318, The PostgreSQL image version jump from 14 to
18.4 in the values.yaml file will break existing deployments due to data
directory incompatibility across major versions. Add a new configuration
parameter (such as postgresql.version or postgresql.majorVersion) to the
values.yaml file to gate this change, include a deprecation warning or migration
flag in the default values, and add comprehensive migration instructions in the
NOTES.txt file that document the required pg_upgrade or dump/restore steps for
users with existing PostgreSQL installations. Ensure the values.yaml comments
clearly warn about the breaking change and provide links to upgrade
documentation.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify chart version was bumped and docs are consistent

echo "=== Chart.yaml version ==="
cat charts/Chart.yaml | grep -E '^version:'

echo -e "\n=== README.md postgres image references ==="
rg -n 'postgres:14\.2|postgres:18\.4' charts/README.md

echo -e "\n=== NOTES.txt upgrade warnings ==="
if [ -f charts/templates/NOTES.txt ]; then
  rg -n -i 'upgrade|migration|postgres.*14|postgres.*18' charts/templates/NOTES.txt || echo "No upgrade warnings found"
else
  echo "NOTES.txt does not exist"
fi

echo -e "\n=== values.yaml comment warnings ==="
rg -n -B2 -A2 'postgres:18\.4' charts/values.yaml

Repository: openshift-hyperfleet/hyperfleet-api

Length of output: 1558

🏁 Script executed:

#!/bin/bash

echo "=== Git diff for Chart.yaml version ==="
git diff HEAD~1 charts/Chart.yaml | grep -E '^\+version:|^-version:' || echo "No version change detected in diff"

echo -e "\n=== Full NOTES.txt content ==="
if [ -f charts/templates/NOTES.txt ]; then
  cat -n charts/templates/NOTES.txt
else
  echo "NOTES.txt not found"
fi

echo -e "\n=== Full values.yaml postgresql section ==="
sed -n '310,330p' charts/values.yaml

Repository: openshift-hyperfleet/hyperfleet-api

Length of output: 2980

Chart.yaml version not bumped despite breaking PostgreSQL upgrade path; README.md stale; missing migration guidance in NOTES.txt.

PostgreSQL 14 → 18 is a breaking change requiring data migration. This PR introduces that incompatibility without:

  1. Incrementing Chart.yaml version (currently 1.1.0, no change detected)
  2. Updating README.md (lines 142, 146, 148 still reference postgres:14.2)
  3. Adding migration warnings to NOTES.txt (no upgrade/migration guidance present)

Users upgrading will face silent database failures without a documented migration path.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@charts/values.yaml` at line 318, Bump the Chart.yaml version to indicate a
breaking change from the PostgreSQL upgrade (PostgreSQL 14 to 18 is a major
version change). Update all references to postgres:14.2 in README.md (lines 142,
146, 148) to reflect the new postgres:18.4 image. Add migration guidance to
NOTES.txt that clearly warns users about the breaking PostgreSQL upgrade and
provides steps for safe data migration during the upgrade process.

# -- Database name
database: hyperfleet
# -- Database user
Expand Down