Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b935b742b2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7cec16e3b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
OCI restores currently create a snapfiles ublk device and mount for every Sandbox. Share one read-only device and mount per resolved snapfiles image and credential scope within the same state directory and mount namespace, while keeping writable rootfs devices and uppers private. Fastlet uses its Pod-scoped state directory; standalone fsb-vm uses the same shared preparation path by default.
Persist Sandbox leases, serialize first preparation across fsb-vm processes, retain a bounded idle cache, and extend OCI Janitor cleanup for caches left by deleted Fastlet Pods. Share snapfiles by default in both standalone fsb-vm and Fastlet; add
cleanup-snapfilesfor explicit idle-cache cleanup. Include focused tests and usage documentation.This branch is based directly on master and contains only snapfiles sharing, lifecycle cleanup, tests, and documentation. The earlier bridge MAC, native ublkd patch, image-cache, and Firecracker launch optimizations are excluded.
Validation
cmd/fsb-vm,internal/runtime/firecracker,internal/janitor.