Repository navigation
build: silence third-party overlaybd compile warnings - #142
Merged
Merged
Conversation
The container-only overlaybd build emits ~200 default g++ warnings (-Wreorder, -Wpessimizing-move, -Wdeprecated-declarations, ...) from the pinned containerd/overlaybd source on every oci-tools image build, burying real errors in CI logs. Pass -w via CMAKE_CXX_FLAGS for this build; it only affects the C++ tool compilation inside the image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The container-only overlaybd build (
build/oci/build-overlaybd.sh, consumed by theoci-toolsimage used by the Builder and Fastlet) emits ~200 default g++ warnings from the pinnedcontainerd/overlaybdsource on every image build:-Wreorder(33),-Wpessimizing-move(22),-Wdeprecated-declarations(17), plus assorted-Wunused-*/-Wstringop-*etc.All of them come from the third-party source, are non-actionable here, and bury real errors in CI logs.
Change
Pass
-DCMAKE_CXX_FLAGS="-w"on the cmake configure line for this container-only build, suppressing the third-party warning noise. Real errors still fail the build; nothing else changes (same pinned revision, same targets, same artifacts).Test plan
oci-toolsimage build completes with a clean log (no C++ warnings from /src/overlaybd)