Skip to content

cudaarithm: fix absdiff for CV_32S minimum value #4237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sridhar-git05 wants to merge 1 commit into
base: 5.x
Choose a base branch
from
Open

cudaarithm: fix absdiff for CV_32S minimum value #4237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions modules/cudaarithm/src/cuda/absdiff_mat.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@
#else

#include "opencv2/cudev.hpp"
#include <climits>

using namespace cv::cudev;

Expand Down Expand Up @@ -77,6 +78,16 @@ namespace
}
};

template <> struct AbsDiffOp1<int> : binary_function<int, int, int>
{
__device__ __forceinline__ int operator ()(int a, int b) const
{
const long long diff = static_cast<long long>(a) - static_cast<long long>(b);
const long long absDiff = diff < 0 ? -diff : diff;
return static_cast<int>(absDiff > INT_MAX ? INT_MAX : absDiff);
}
};

template <typename ScalarDepth> struct TransformPolicy : DefaultTransformPolicy
{
};
Expand Down
17 changes: 17 additions & 0 deletions modules/cudaarithm/test/test_element_operations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,6 +1404,23 @@ CUDA_TEST_P(AbsDiff, Array)
}
}

CUDA_TEST_P(AbsDiff, IntMin)
{
if (depth != CV_32S)
return;

cv::Mat src1 = (cv::Mat_<int>(1, 2) << std::numeric_limits<int>::min(), 0);
cv::Mat src2 = (cv::Mat_<int>(1, 2) << 0, std::numeric_limits<int>::min());

cv::Mat expected = (cv::Mat_<int>(1, 2) << std::numeric_limits<int>::max(),
std::numeric_limits<int>::max());

cv::cuda::GpuMat dst;
cv::cuda::absdiff(loadMat(src1), loadMat(src2), dst);

EXPECT_MAT_NEAR(expected, dst, 0.0);
}

CUDA_TEST_P(AbsDiff, Scalar)
{
cv::Mat src = randomMat(size, depth);
Expand Down