Repository navigation
cudastereo: avoid overflow in StereoSGM aggregate buffer layout - #4236
Open
sridhar-git05 wants to merge 1 commit into
Open
sridhar-git05 wants to merge 1 commit into
sridhar-git05 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Fixes #4112.
StereoSGM stored the aggregated path costs for all paths in a single one-row buffer. The buffer size was calculated as:
width * height * numDisparities * num_pathsFor sufficiently large images and disparity counts, this value can exceed the range of the signed 32-bit integer used by the
GpuMatallocation interface.Store each path in a separate row instead. The resulting layout is:
rows = num_pathscols = width * height * numDisparitiesThis keeps the per-row size within the existing integer-based
GpuMatinterface while preserving the same logical path/disparity data.Updated
PathAggregationandWinnerTakesAllto use the new row-based layout and updated the CPU reference test accordingly.Added a high-level
StereoSGMregression test coveringMODE_HHwith 256 disparities.Testing:
StereoSGM_AggregatedBufferLayout: 1/1 passedStereoSGM_WinnerTakesAll: 8/8 passedStereoSGM_PathAggregation: 96/96 passedgit diff --checkpasses