Skip to content

Scrub GitHub and GitLab authentication token aliases - #119

Merged
frantic-openai merged 2 commits into
mainfrom
codex/scrub-tracker-token-aliases
Aug 12, 2026
Merged

Scrub GitHub and GitLab authentication token aliases#119
frantic-openai merged 2 commits into
mainfrom
codex/scrub-tracker-token-aliases

Conversation

@frantic-openai

@frantic-openai frantic-openai commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

Context

GitHub and GitLab authentication aliases let coding agents inherit tracker credentials and bypass Symphony's host-side boundary.

Thanks @genforAI for reporting this issue.

TL;DR

Keep GitHub and GitLab authentication-token aliases out of coding-agent environments.

Summary

  • Scrub GitHub CLI token aliases in the existing GitHub provider client.
  • Scrub GitLab access-token aliases while preserving distinct CI job credentials.
  • Document provider credential isolation, current authentication guidance, and existing adapter test coverage.

Alternatives

  • Fix GitHub only; rejected because GitLab exposes the same authentication-alias weakness.
  • Add another child-process test; existing launcher-isolation coverage already verifies that boundary.

Test Plan

  • make -C elixir all (296 tests, 0 failures, 100% coverage)
  • Focused GitHub, GitLab, and existing app-server credential-isolation tests

frantic-openai and others added 2 commits August 12, 2026 11:11
Summary:
- Remove GitHub and GitLab auth aliases from coding-agent environments.
- Clarify the tracker credential-isolation contract and adapter docs.
- Extend existing provider and session-binding assertions.

Rationale:
- Provider CLIs can authenticate with aliases that previously bypassed
  Symphony's host-side credential boundary.
- Preserve CI_JOB_TOKEN because it is a distinct CI credential.

Tests:
- make -C elixir all (296 tests, 0 failures, 100% coverage)

Co-authored-by: Codex <codex@openai.com>
Summary:
- Describe provider credential isolation without exhaustive alias lists.
- Direct implementations to current provider authentication guidance.

Rationale:
- Supported credential variables and aliases can change over time.
- Avoid duplicating provider token inventories in documentation.

Tests:
- make -C elixir all (296 tests, 0 failures, 100% coverage)

Co-authored-by: Codex <codex@openai.com>
@frantic-openai
frantic-openai merged commit 8001b52 into main Aug 12, 2026
4 checks passed
@frantic-openai
frantic-openai deleted the codex/scrub-tracker-token-aliases branch August 12, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant