build(plugin): bundle verified native runtime artifacts - #797
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
9cea871 to
14e65b8
Compare
14e65b8 to
239b8e8
Compare
bd11e36 to
b9231c7
Compare
mldangelo-oai
left a comment
There was a problem hiding this comment.
Re-reviewed the exact current head after the stacked fixes. The packaged-artifact behavior looks sound and the earlier manifest/docs comments are resolved. I found three concrete CI/test simplifications below.
0e3c1d9 to
bfd9a26
Compare
| uses: ./.github/workflows/container-validate.yml | ||
|
|
||
| authorize: | ||
| if: github.repository == 'openai/codex-security' && github.event_name != 'pull_request' |
There was a problem hiding this comment.
[P3] Remove the dead PR branches
This workflow no longer has a pull_request trigger (and it does not expose workflow_call), so this ternary always selects container-release-publish and the authorize check at line 27 is always true on the event side. Could we collapse this to concurrency: container-release-publish and make authorize's if just the repository guard? That preserves release serialization and fork protection while removing two dead YAML branches.
Summary
Include verified native OS primitives in the standalone plugin and npm package so TypeScript helpers can run without compiling or downloading native code at runtime.
Changes
plugin-files.json. Missing declared inputs fail the build; undeclared files are excluded.Testing
Risk and rollout
Stacked on #796. Adds about 3.8 MB of native binaries and notices before compression. Source builds require the documented prebuilt inputs. Hosted CI covers universal artifact assembly and downstream platform jobs. Product helpers switch to TypeScript in subsequent changes.
Public disclosure review