feat: samplers are self sufficient - #2341
Open
thompson-tomo wants to merge 1 commit into
Open
thompson-tomo wants to merge 1 commit into
thompson-tomo wants to merge 1 commit into
Conversation
thompson-tomo
changed the title
thompson-tomo
force-pushed
the
samplar_selfContained
branch
from
September 8, 2026 06:25
54011d0 to
2cff478
Compare
thompson-tomo
marked this pull request as ready for review
September 8, 2026 14:28
thompson-tomo
requested review from
a team,
dazuma,
fbogsany,
kaylareopelle,
mwear,
robbkidd,
robertlaurin and
xuan-cao-swi
as code owners
September 8, 2026 14:29
thompson-tomo
force-pushed
the
samplar_selfContained
branch
from
September 8, 2026 14:29
2cff478 to
2ec103f
Compare
thompson-tomo
force-pushed
the
samplar_selfContained
branch
from
September 9, 2026 02:49
2ec103f to
e64ed73
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The samplers are now responsible for obtaining their own config from the environment in cases where no config is supplied.
This makes trace provider only need to know the name of the sampler to be used.