Deprecate OpenCensus shim public API - #8674
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8674 +/- ##
============================================
+ Coverage 91.47% 91.62% +0.15%
+ Complexity 10465 10327 -138
============================================
Files 1021 1003 -18
Lines 27694 27138 -556
Branches 3247 3187 -60
============================================
- Hits 25333 24866 -467
+ Misses 1617 1566 -51
+ Partials 744 706 -38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The Windows Java 17 job failed during Gradle configuration because Maven Central returned HTTP 429 while resolving Kotlin 2.3.21, before project compilation started. All other OS/JDK builds, both GraalVM builds, CodeQL, API checks, coverage, links, and EasyCLA passed. I do not have permission to rerun the upstream workflow; could a maintainer rerun the failed jobs when convenient? |
Pull request dashboard statusWaiting on reviewers · refreshed 2026-08-03 22:27 UTC Review the latest changes. Status above doesn't look right?
|
jack-berg
left a comment
There was a problem hiding this comment.
Couple of small comments. Thanks!
| * <p>To use, register with {@link SdkMeterProviderBuilder#registerMetricProducer(MetricProducer)}. | ||
| * | ||
| * @deprecated OpenCensus compatibility is deprecated in the OpenTelemetry specification. This shim | ||
| * is deprecated accordingly. Migrate OpenCensus instrumentation to the OpenTelemetry APIs. |
There was a problem hiding this comment.
For the deprecation messages, can you follow the pattern used in the deprecated ZipkinExporter? I.e. link to the spec PR where opencensus was deprecated and indicate that we stop publishing the artifact after June 2027. Use this updated message consistently in all places.
There was a problem hiding this comment.
Addressed in dc333b8. All six deprecation notices now follow the linked specification pattern, reference open-telemetry/opentelemetry-specification#5138, and state that the artifact will no longer be published after June 2027. The targeted shim check and Javadoc task pass locally.
|
/dashboard route:reviewers |
|
@LarryHu0217 routed this pull request to reviewers. |
| > OpenCensus compatibility is deprecated in the OpenTelemetry specification, and this shim is | ||
| > deprecated accordingly. It remains available for legacy compatibility, but users should migrate | ||
| > OpenCensus instrumentation to the OpenTelemetry APIs. See the | ||
| > [OpenTelemetry specification guidance on OpenCensus compatibility](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/opencensus.md). |
There was a problem hiding this comment.
Can you also update the artifact table in the root README.md to indicate that the opencensus is entry. Check out the opentracing entry for an example: https://github.com/open-telemetry/opentelemetry-java/blame/bc956bcf7d402104fe59af8ba31ff9b73849e9b7/README.md#L146
(Sorry meant to include this comment with my initial review but apparently I forgot to hit the submit button)
There was a problem hiding this comment.
Addressed in d0f9df6. The root artifact table now marks the OpenCensus shim as deprecated, matching the OpenTracing entry. The spotless and opencensus-shim checks pass locally.
Summary
This does not change runtime behavior or define the post-deprecation maintenance policy discussed in the issue.
Fixes #8673
Testing
./gradlew :opencensus-shim:spotlessApply :opencensus-shim:check./gradlew :opencensus-shim:build