Skip to content

fix(test): align testRestartPolicy with the runtime's exit() contract #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Meldiron merged 1 commit into from
Aug 19, 2026
Merged

fix(test): align testRestartPolicy with the runtime's exit() contract #249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/e2e/ExecutorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -797,7 +797,11 @@ public function testRestartPolicy(): void
'runtimeEntrypoint' => 'cp /tmp/code.tar.gz /mnt/code/code.tar.gz && nohup helpers/start.sh "' . $command . '"',
'restartPolicy' => 'always'
]);
$this->assertEquals(500, $response['headers']['status-code']);
// The runtime reports the function's exit() as a failed execution, so the
// executor call itself succeeds and carries statusCode 500. The server
// process still dies afterwards, which is what the restart count asserts.
$this->assertEquals(200, $response['headers']['status-code']);
$this->assertEquals(500, $response['body']['statusCode']);

\sleep(5);

Expand All @@ -807,7 +811,8 @@ public function testRestartPolicy(): void
'image' => 'openruntimes/php:v5-8.1',
'runtimeEntrypoint' => 'cp /tmp/code.tar.gz /mnt/code/code.tar.gz && nohup helpers/start.sh "' . $command . '"'
]);
$this->assertEquals(500, $response['headers']['status-code']);
$this->assertEquals(200, $response['headers']['status-code']);
$this->assertEquals(500, $response['body']['statusCode']);

\sleep(5);

Expand Down