feat(flutter): derive OPEN_RUNTIMES_BUILD_KEYS from user variables - #248
Merged
Merged
Conversation
Captures user-supplied variable keys before executor merges its own internal vars, then adds OPEN_RUNTIMES_BUILD_KEYS as a space-separated list.
Greptile SummaryThe PR captures user-provided variable names before adding executor-managed variables and exposes those names through
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains in the eligible follow-up review scope. No blocking failure remains. Important Files Changed
Reviews (5): Last reviewed commit: "fix(maintenance): don't reap runtimes th..." | Re-trigger Greptile |
Meldiron
approved these changes
Aug 17, 2026
dart2js requires more than 512MB to compile Flutter web. Set memory to 2048MB to match the minimum Deployments.php already enforces for Sites builds in production.
The maintenance sweep treated any runtime whose `updated` timestamp was older than OPR_EXECUTOR_INACTIVE_THRESHOLD as idle. That timestamp is only refreshed once creation finishes, so a build taking longer than the threshold (60s in CI) had its container force-removed mid-build. The build command then failed and /v1/runtimes answered 400 build_failed. This is what broke testBuildKeysFlutter in CI: the Flutter build plus the 3.6GB image pull runs well past 60s, while every other e2e build finishes under it. Skip runtimes that have not finished initialising. Also restore the try/catch around the container removal that was dropped when maintenance was extracted from Docker.php. Without it, removing an already-gone container throws Orchestration inside the maintenance coroutine and takes the whole executor process down. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Captures user-supplied variable keys before executor merges its own internal vars, then adds OPEN_RUNTIMES_BUILD_KEYS as a space-separated list.