Skip to content

CI rekey fails on liboqs main after Classic McEliece default-off (#2640) #205

Closed

Description

@mkhellat

Summary

Ubuntu CI rekey regress is red against current liboqs main. This looks
independent of open feature PRs: the same failure reproduces on an unpatched
OQS-v10 tree when liboqs is at tip.

Root cause appears to be liboqs
open-quantum-safe/liboqs#2640
(9fb80ab): Classic McEliece is disabled by default, while this repo still
lists Classic McEliece KEX in oqs-template/generate.yml and exercises them in
regress. With default liboqs cmake flags (oqs-scripts/build_liboqs.sh passes
through empty LIBOQS_CMAKE_ARGS), those KEMs are missing at runtime →
ssh failed / no rekeying occurred on classic-mceliece-*.

Evidence (fork-only, rekey-only)

Narrow workflow: build once, then
make t-exec -e LTESTS=rekey (not the full suite).

Repro workflow (fork):
https://github.com/mkhellat/openssh/blob/ci/investigate-rekey-failures/.github/workflows/investigate-ubuntu.yaml

liboqs ref Role rekey
e77d81dab791 (main tip) after #2640 fail
4778aa5044bf parent before #2640 window pass (ok rekey)
e1f480f382d9 older pass (ok rekey)

On tip, classical KEX and non-McEliece PQ KEX (sntrup, mlkem, frodo, kyber, bike, …)
progress normally; the first failures are exactly the Classic McEliece family,
e.g. classic-mceliece-348864-sha256.

Example fail run:
https://github.com/mkhellat/openssh/actions/runs/41172651753
Example pass (pre-#2640):
https://github.com/mkhellat/openssh/actions/runs/41172654987

This matches the red Ubuntu Checks / CI VM rekey / ssh-failed pattern on
recent PRs (including draft #203 / #204), which share floating liboqs main.

Suggested directions (maintainers choose)

A. CI / build unblock (smallest): pass
-DOQS_ENABLE_KEM_CLASSIC_MCELIECE=ON via LIBOQS_CMAKE_ARGS in the Ubuntu
(and other) workflows that still expect McEliece in the algorithm template.
build_liboqs.sh already supports this.

B. Align with liboqs default: remove Classic McEliece from
oqs-template/generate.yml (regenerate) so OpenSSH no longer offers/tests
algs liboqs does not build by default. Matches the spirit of #2640 (and what
liboqs did for its own weekly kem-bench).

C. Runtime gating: skip / omit KEX entries when
OQS_KEM_alg_is_enabled() (or OQS_KEM_new == NULL) so default-off families
do not fail regress when someone builds without opting them in.

D. Stopgap only: pin CI LIBOQS_BRANCH / SHA to pre-9fb80ab. Unblocks
PRs but fights floating main.

I’d lean A for immediate CI green, then B and/or C so defaults stay
aligned with liboqs. Happy to send a follow-up PR once you prefer a direction.

Non-goals

This issue is not claiming a bug in #203 / #204 patch content; those remain
draft until shared CI is addressed.

Activity

  1. baentsch commented on Nov 4, 2026

    @baentsch
    Member

    fwiw, I'd prefer B right away as McEliece will be dropped eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions