Repository navigation
Fix two CMP warnings in CMake >= 4.1 and 4.4 - #2704
Merged
Merged
Conversation
Jacalz
requested review from
baentsch,
dstebila and
xuganyu96
as code owners
November 13, 2026 16:26
Member
|
Thanks very much for the fix, @Jacalz! Would you be able to amend your commit with the DCO sign-off? |
This avoids two warnings that pop up with newer CMake versions. In the first case, we don't want to expand any variables other than our own. In the second, CMake accidentally allowed MSVC to be set for assembly. Simply turning it off is fine as our assembly files are gated for other platforms anyway. Signed-off-by: Jacalz <jacalz@tutanota.com>
Jacalz
force-pushed
the
cmake-policy-fixes
branch
from
November 17, 2026 19:55
5531416 to
5e4bc4f
Compare
Contributor
Author
|
Absolutely. Should be fine now :) |
dstebila
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids two warnings that pop up with newer CMake versions. In the first case, we don't want to expand any variables other than our own. Because of how CMake handles if-statements, this led to us reading and expanding external variables even though it was gated behind the first clause.
In the second, CMake accidentally allowed MSVC to be set for assembly. Simply turning it off is fine as our assembly files are gated for other platforms anyway.