Skip to content

Fix strdup deprecated in MSVC CRT - #2703

Merged
dstebila merged 2 commits into
open-quantum-safe:mainfrom
Jacalz:msvc-strdup
Nov 18, 2026
Merged

dstebila merged 2 commits into
open-quantum-safe:mainfrom
Jacalz:msvc-strdup

Conversation

@Jacalz

@Jacalz Jacalz commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Compiling with /sdl on MSVC promotes C4996 to an error so build fails. Use _strdup to fix the error.
This does not affect any of the algorithms available or similar.

@Jacalz
Jacalz requested a review from dstebila as a code owner November 13, 2026 16:05
@dstebila

Copy link
Copy Markdown
Member

Do you mean /sdl, not /stl?

Comment thread src/common/common.c Resolved
@dstebila

Copy link
Copy Markdown
Member

Can you update your commit with a DCO sign-off?

@Jacalz

Jacalz commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Do you mean /sdl, not /stl?

Oh yes, sorry about that. I'll have that fixed

Compiling with /sdl on MSVC promotes C4996 to an error so build fails. Use _strdup to fix the error.

Signed-off-by: Jacalz <jacalz@tutanota.com>
@Jacalz

Jacalz commented Nov 17, 2026

Copy link
Copy Markdown
Contributor Author

Should be fine now :)

@Jacalz
Jacalz requested a review from dstebila November 17, 2026 20:01
@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 79.969% (+0.03%) from 79.943% — Jacalz:msvc-strdup into open-quantum-safe:main

@dstebila
dstebila merged commit e161c16 into open-quantum-safe:main Nov 18, 2026
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants