feat: per-user favorites — asset_favorite overlay, viewer hearts, cross-scope filters (#763)

docs/docs/guides/switch-back-to-immich.md

@@ -11,6 +11,7 @@ This guide walks through switching a Gallery instance back to upstream [Immich](
 - Pet detection results, and every individual pet you named through pet recognition
 - Asset duplicate checksums
 - Library sync state
+- Favorites belonging to anyone other than the asset's owner (see note below)
 
 Assets you uploaded through Gallery are preserved, as long as they exist in Immich-native tables (which is the normal case for every file uploaded via the web or mobile app).
 
@@ -115,8 +116,9 @@ Watch the server log. A successful boot ends with the usual Immich startup banne
 
 Here is what the cleanup script changes:
 
-- It drops the Gallery-only tables `shared_space*`, `album_space_asset*`, `library_user`, `library_audit`, `library_asset_audit`, `shared_space_library*`, `face_identity*`, `face_repair*`, `pet_search`, `user_group`, `user_group_member`, `classification_category`, `classification_prompt_embedding`, `storage_migration_log` and `asset_duplicate_checksum`.
+- It drops the Gallery-only tables `shared_space*`, `album_space_asset*`, `library_user`, `library_audit`, `library_asset_audit`, `shared_space_library*`, `face_identity*`, `face_repair*`, `pet_search`, `user_group`, `user_group_member`, `classification_category`, `classification_prompt_embedding`, `storage_migration_log`, `asset_duplicate_checksum`, `asset_favorite` and `asset_favorite_audit`.
 - It drops the Gallery-added columns `person.type`, `person.species`, `asset_job_status.petsDetectedAt`, `asset_job_status.classifiedAt` and `library.createId`.
+- It restores `asset.isFavorite`, an upstream Immich column Gallery moved into the `asset_favorite` overlay so each space member can favorite independently, before dropping `asset_favorite`, and backfills it from the overlay — but only for the asset's owner. Favorites belonging to anyone else (for example, a shared-space viewer who favorited another member's photo) have no equivalent in plain Immich's single-favorite-flag model and are discarded. Your own favorites on your own assets are preserved.
 - It drops the Gallery-only functions and triggers that reference the dropped tables.
 - It strips the `classification` key out of the `system-config` row in `system_metadata`.
 - It deletes fork migration rows from `kysely_migrations` and `migration_overrides`, so upstream Immich's migrator does not see them as unknown migrations.

e2e/src/specs/server/api/asset-copy.e2e-spec.ts

@@ -1,4 +1,4 @@
-import { type LoginResponseDto } from '@immich/sdk';
+import { type LoginResponseDto, SharedSpaceRole } from '@immich/sdk';
 import { type Actor, authHeaders } from 'src/actors.js';
 import { createUserDto } from 'src/fixtures.js';
 import { errorDto } from 'src/responses.js';
@@ -203,6 +203,69 @@ describe('PUT /assets/copy', () => {
     expect((after.body as { isFavorite: boolean }).isFavorite).toBe(false);
   });
 
+  // #763 slice 7 (E20): favorite carries the ACTING user's overlay row, never every user who
+  // favorited the source. `other` gains read access to both assets via a shared space (viewer
+  // role is enough under Permission.AssetRead, per #763 slice 2) purely so they can favorite the
+  // source and later read the target back — `other` still can't call PUT /assets/copy itself,
+  // since Permission.AssetCopy stays owner-only (asset.service.spec.ts already pins that).
+  it("copies only the ACTING user's favorite of the source, not another user's (E20)", async () => {
+    const [sourceId, targetId] = await createOwnerPair();
+
+    const space = await utils.createSpace(owner.accessToken, { name: 't26-copy-favorite-space' });
+    await utils.addSpaceMember(owner.accessToken, space.id, { userId: other.userId, role: SharedSpaceRole.Viewer });
+    await utils.addSpaceAssets(owner.accessToken, space.id, [sourceId, targetId]);
+
+    // Both the owner (acting user) and `other` favorite the SOURCE — independent per-user facts.
+    const ownerFav = await request(app)
+      .put('/assets/favorites')
+      .set(asBearerAuth(owner.accessToken))
+      .send({ ids: [sourceId], isFavorite: true });
+    expect(ownerFav.status).toBe(204);
+
+    const otherFav = await request(app)
+      .put('/assets/favorites')
+      .set(asBearerAuth(other.accessToken))
+      .send({ ids: [sourceId], isFavorite: true });
+    expect(otherFav.status).toBe(204);
+
+    const copy = await request(app)
+      .put('/assets/copy')
+      .set(asBearerAuth(owner.accessToken))
+      .send({ sourceId, targetId, favorite: true });
+    expect(copy.status).toBe(204);
+
+    // The acting user (owner) gets the target favorited (E20 happy path).
+    const ownerView = await request(app).get(`/assets/${targetId}`).set(asBearerAuth(owner.accessToken));
+    expect((ownerView.body as { isFavorite: boolean }).isFavorite).toBe(true);
+
+    // `other` favorited the SOURCE but never acted on this copy — their view of the target must
+    // stay unfavorited. This is the negative the old global-column copy could not express.
+    const otherView = await request(app).get(`/assets/${targetId}`).set(asBearerAuth(other.accessToken));
+    expect((otherView.body as { isFavorite: boolean }).isFavorite).toBe(false);
+  });
+
+  it('clears the target favorite when the acting user did not favorite the source, even though favorite defaults to true', async () => {
+    const [sourceId, targetId] = await createOwnerPair();
+
+    // Owner favorites the TARGET directly (unrelated to the upcoming copy) but never favorites
+    // the source. A working copy still "copies the status" — including a false one — for the
+    // acting user, mirroring the old column-overwrite semantics scoped to the actor.
+    const preFav = await request(app)
+      .put('/assets/favorites')
+      .set(asBearerAuth(owner.accessToken))
+      .send({ ids: [targetId], isFavorite: true });
+    expect(preFav.status).toBe(204);
+
+    const copy = await request(app)
+      .put('/assets/copy')
+      .set(asBearerAuth(owner.accessToken))
+      .send({ sourceId, targetId });
+    expect(copy.status).toBe(204);
+
+    const after = await request(app).get(`/assets/${targetId}`).set(asBearerAuth(owner.accessToken));
+    expect((after.body as { isFavorite: boolean }).isFavorite).toBe(false);
+  });
+
   it('owner can copy: album associations are propagated source → target', async () => {
     const [sourceId, targetId] = await createOwnerPair();