Skip to content

refactor(local-setup): Move local setup using KinD to ODG#865

Open
8R0WNI3 wants to merge 1 commit into
open-component-model:masterfrom
8R0WNI3:local-setup
Open

refactor(local-setup): Move local setup using KinD to ODG#865
8R0WNI3 wants to merge 1 commit into
open-component-model:masterfrom
8R0WNI3:local-setup

Conversation

@8R0WNI3

@8R0WNI3 8R0WNI3 commented Jun 18, 2026

Copy link
Copy Markdown
Member

What this PR does / why we need it:
For reference, see open-component-model/open-delivery-gear#125

Which issue(s) this PR fixes:
Fixes open-component-model/open-delivery-gear#94

Special notes for your reviewer:

Release note:


@8R0WNI3 8R0WNI3 self-assigned this Jun 18, 2026
@8R0WNI3 8R0WNI3 requested a review from a team as a code owner June 18, 2026 09:09
@8R0WNI3 8R0WNI3 added kind/refactor refactoring, maintenance, etc. area/ipcei Important Project of Common European Interest labels Jun 18, 2026
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@8R0WNI3, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 52 minutes and 54 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8ef5abaf-9e3d-424d-a1dc-75dac2b84fb7

📥 Commits

Reviewing files that changed from the base of the PR and between ecaae8c and 2896aa2.

📒 Files selected for processing (20)
  • Makefile
  • README.md
  • docs/local_setup.rst
  • local-setup/kind/cluster/Chart.yaml
  • local-setup/kind/cluster/delivery-db-pv/pv.yaml
  • local-setup/kind/cluster/delivery-db-pv/pvc.yaml
  • local-setup/kind/cluster/templates/_extra_mounts.tpl
  • local-setup/kind/cluster/templates/_extra_port_mappings.tpl
  • local-setup/kind/cluster/templates/_kubeadm_config_patches.tpl
  • local-setup/kind/cluster/templates/cluster.yaml
  • local-setup/kind/cluster/values-bootstrapping.yaml
  • local-setup/kind/cluster/values-delivery-dashboard.yaml
  • local-setup/kind/cluster/values-delivery-db.yaml
  • local-setup/kind/cluster/values-delivery-service.yaml
  • local-setup/kind/cluster/values-extensions.yaml
  • local-setup/kind/cluster/values.yaml
  • local-setup/kind/kind-down.sh
  • local-setup/kind/kind-up.sh
  • local-setup/kind/kind-update.sh
  • local-setup/local-setup.md
📝 Walkthrough

Walkthrough

All local Kind cluster setup artifacts are removed from the repository: Makefile kind-up/kind-update/kind-down targets, three shell scripts, the local-setup/kind/cluster Helm chart with its templates and values files, Kubernetes PV/PVC manifests, and the local-setup documentation. Two documentation links in README.md and docs/local_setup.rst are updated to reference the new location in the open-delivery-gear repository.

Changes

Local Kind Setup Removal and Doc Link Updates

Layer / File(s) Summary
Remove Kind cluster scripts, chart, manifests, and values
Makefile, local-setup/kind/kind-up.sh, local-setup/kind/kind-down.sh, local-setup/kind/kind-update.sh, local-setup/kind/cluster/Chart.yaml, local-setup/kind/cluster/templates/*, local-setup/kind/cluster/delivery-db-pv/*, local-setup/kind/cluster/values*.yaml, local-setup/local-setup.md
Deletes all Kind cluster provisioning: Makefile targets and exported variables (REPO_ROOT, CLUSTER_NAME, KUBECONFIG, PATH_CLUSTER_CHART), the three lifecycle scripts (up/update/down), the full Helm chart (cluster template, extra-mounts/port-mappings/kubeadm Helm helpers), PV/PVC manifests for delivery-db, and all values overrides (bootstrapping, delivery-db, delivery-dashboard, delivery-service, extensions, cluster).
Update local-setup doc links to open-delivery-gear
README.md, docs/local_setup.rst
Replaces the odg-core master branch URL with the open-delivery-gear main branch URL for the local-setup guide in both the README "Getting Started using Kind" section and the RST documentation reference.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Snip snip snip, the kind cluster's gone,
No more kind-up at the break of dawn.
The scripts have hopped to a brand new place,
A fresh repository, a tidier space.
The links now point where the bunnies roam—
open-delivery-gear is the new kind home! 🏠

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: refactoring local KinD setup by moving it to the ODG project.
Description check ✅ Passed The description references the external PR and linked issue with a clear release note, following the template structure mostly.
Linked Issues check ✅ Passed Issue #94 proposes streamlining ODG's OCM Component Tree through a diagram, and this PR consolidates local setup capabilities which aligns with the architectural reorganization.
Out of Scope Changes check ✅ Passed All changes are focused on removing local KinD setup files and updating documentation links, which is directly within the scope of moving local setup to an external repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/local_setup.rst`:
- Line 13: The GitHub URL on line 13 in the local setup guide uses a
directory-style path that will fail. Update the link from
https://github.com/open-component-model/open-delivery-gear/blob/main/local-setup
to point either at the tree view by changing blob/main to tree/main/local-setup,
or directly to the actual guide file by appending the appropriate file path and
extension. Verify the updated link resolves correctly before committing.

In `@README.md`:
- Line 32: The link in the README.md file pointing to the local-setup guide uses
a directory-like path without a concrete file name, which results in a broken
redirect. Update the link target to point to a specific file path (such as the
README.md file within the local-setup directory) or use the repository tree URL
format instead of the blob URL for the directory path to ensure the link
resolves correctly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 82493cb5-8f3c-447b-95be-2a5544a04677

📥 Commits

Reviewing files that changed from the base of the PR and between 0c363d7 and ecaae8c.

📒 Files selected for processing (20)
  • Makefile
  • README.md
  • docs/local_setup.rst
  • local-setup/kind/cluster/Chart.yaml
  • local-setup/kind/cluster/delivery-db-pv/pv.yaml
  • local-setup/kind/cluster/delivery-db-pv/pvc.yaml
  • local-setup/kind/cluster/templates/_extra_mounts.tpl
  • local-setup/kind/cluster/templates/_extra_port_mappings.tpl
  • local-setup/kind/cluster/templates/_kubeadm_config_patches.tpl
  • local-setup/kind/cluster/templates/cluster.yaml
  • local-setup/kind/cluster/values-bootstrapping.yaml
  • local-setup/kind/cluster/values-delivery-dashboard.yaml
  • local-setup/kind/cluster/values-delivery-db.yaml
  • local-setup/kind/cluster/values-delivery-service.yaml
  • local-setup/kind/cluster/values-extensions.yaml
  • local-setup/kind/cluster/values.yaml
  • local-setup/kind/kind-down.sh
  • local-setup/kind/kind-up.sh
  • local-setup/kind/kind-update.sh
  • local-setup/local-setup.md
💤 Files with no reviewable changes (18)
  • local-setup/kind/cluster/templates/cluster.yaml
  • local-setup/kind/cluster/delivery-db-pv/pv.yaml
  • local-setup/kind/cluster/values-delivery-dashboard.yaml
  • local-setup/kind/kind-down.sh
  • local-setup/kind/cluster/values.yaml
  • local-setup/kind/cluster/delivery-db-pv/pvc.yaml
  • local-setup/kind/cluster/values-extensions.yaml
  • local-setup/kind/cluster/templates/_extra_port_mappings.tpl
  • local-setup/local-setup.md
  • local-setup/kind/cluster/templates/_kubeadm_config_patches.tpl
  • local-setup/kind/cluster/values-bootstrapping.yaml
  • Makefile
  • local-setup/kind/cluster/values-delivery-service.yaml
  • local-setup/kind/kind-update.sh
  • local-setup/kind/cluster/values-delivery-db.yaml
  • local-setup/kind/cluster/templates/_extra_mounts.tpl
  • local-setup/kind/kind-up.sh
  • local-setup/kind/cluster/Chart.yaml

Comment thread docs/local_setup.rst Outdated
Comment thread README.md Outdated
For reference, see open-component-model/open-delivery-gear#125

Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipcei Important Project of Common European Interest kind/refactor refactoring, maintenance, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streamline ODG's OCM Component Tree

1 participant