Bugfix: make kind-up on darwin platform#825
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR updates local kind cluster Helm values and scripts: clears bootstrap crypto mappings and simplifies OCM repo mapping, adds ingress for delivery services, replaces DB chart volumePermissions with an initContainer to chown /data, includes secrets values in helm calls, makes port cleanup tolerant, updates extensions toggles, and adds Podman/macOS docs. ChangesLocal Setup Configuration and Documentation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@titanlien, thank you for your contribution! However, it appears these changes are only necessary because the OCM component named |
8ced905 to
1c88fbb
Compare
|
@8R0WNI3 thanks for sharing your road map with, I will keep an eye on it. If you can share release schedule with me as well. That will be great. |
|
You'll find the start and the estimated target date in the linked EPIC :-) |
21c9906 to
30c2e34
Compare
On Linux, rootless Podman requires kind to run inside a systemd scope with `Delegate=yes` to manage cgroups. Wrap `kind create cluster` with `systemd-run --scope --user -p "Delegate=yes"` when `KIND_EXPERIMENTAL_PROVIDER=podman` and `systemd-run` is available. On macOS, Podman Desktop runs rootless by default inside its Linux VM, which triggers the same error. Document the fix: switch the Podman machine to rootful mode via `podman machine set --rootful`. Update local-setup.md with a dedicated "Using Podman as container engine" section covering both platforms. Signed-off-by: Titan Lien <6195019+titanlien@users.noreply.github.com>
30c2e34 to
28c165a
Compare
What this PR does / why we need it:
fix(kind-up): fix make kind-up running on Darwin platform5 files changed to fix
make kind-up/make kind-updateon macOS:1.
values-delivery-service.yaml— AddedingresssectionThe
service-ingress.yamltemplate dereferences.Values.ingress.annotationswithout a nil guard → Helm nil pointer error. Addedingress.hosts,ingress.annotations: {},ingress.disableTls: true.2.
values-delivery-dashboard.yaml— AddedingresssectionSame issue in
dashboard-ingress.yaml— withoutingress.hosts, the rendered Ingress has no rules and no defaultBackend → Kubernetes rejects it as invalid.3.
values-delivery-db.yaml— ReplacedvolumePermissionswith custom init containervolumePermissions: enabled: trueinjects a Bitnami init container usingdocker.io/bitnami/os-shell:12-debian-12-r41, which doesn't exist on Docker Hub (manifest unknown on macOS). Replaced with a customprimary.initContainersentry that reuses the already-mirroredeurope-docker.pkg.dev/gardener-project/releases/odg/postgres:16.8.0tochown -R 1001:1001 /data.4.
values-bootstrapping.yaml— Two fixes for compatibility with installed image0.1212.0crypto.mappings: []— The installedodg/extensions_cfg.pydacite-deserializesCryptoMappingwhose__post_init__callsshared_cfg_lookup(). Dacite triesSharedCfgGitHubReferencefirst (requiresrepository) →MissingValueError. Empty list avoids constructing anyCryptoMappingobjects.ocm_repo_mappings— The installedlookups.pyusescnudie.retrieve.OcmRepositoryMappingEntry(onlyrepository+prefixsupported). Old config hadtype: virtual(norepositoryfield) andprefixes(plural). Fixed by removing the virtual entry and renamingprefixes→prefix.5.
kind-update.sh— Added|| trueto port-forward kill commandxargs killexits with code 1 on macOS when no existing kubectl port-forward is running →makefails.|| truesuppresses the error when there's nothing to kill.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: