Repository navigation
Conversation
Accept hash characters in short MESSAGE classes. Split flow statements at unquoted terminators, expand colon chains, retain request-module field associations and distinguish CHAIN conditions. Seven focused converter/parser regressions pass; five reproduce failures on upstream main before the fix. Generated source passes the converter parser validation. SAP exports are not used by these tests.
Member
|
thanks hmm, not sure why the unit tests did not trigger, probably github having a bad day, I'll push some changes to main, then we can update this branch |
|
|
Member
|
ah, sign the CLA, and dont |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The converter drops or misclassifies valid tokens in classic dialog inputs:
MESSAGE e001(z#)generates invalid ABAP, colon-chainedFIELD ... MODULEstatements lose handlers, and multiple flow statements on one line lose the phase or module. A standaloneMODULEin value/help-request flow can also call.pushon an object and throw.Split flow statements outside quoted text, expand chains while retaining source lines, preserve each request module's field association and distinguish
ON CHAIN-INPUT/ON CHAIN-REQUEST. Accept#in the short MESSAGE class while retaining existing default-class handling. Fixtures are synthetic.Validation: seven focused regression cases pass; five fail against base
50186bdbefore these fixes. Fifteen neighboring MESSAGE/dynpro converter tests pass. Generated ABAP is checked by the converter's parser. Repository ABAP lint (2.120.73, unchanged abaplint.jsonc) reports zero issues across 1,229 files. An independent review found no remaining code blockers; its source-line finding is fixed and covered by a regression assertion. Full CI and application acceptance are not claimed.