Skip to content

Fix message-class and screen-flow parsing in the converter - #213

Open
flujo-app wants to merge 2 commits into
open-abap:mainfrom
flujo-app:fix/converter-message-flow
Open

flujo-app wants to merge 2 commits into
open-abap:mainfrom
flujo-app:fix/converter-message-flow

Conversation

@flujo-app

Copy link
Copy Markdown

The converter drops or misclassifies valid tokens in classic dialog inputs: MESSAGE e001(z#) generates invalid ABAP, colon-chained FIELD ... MODULE statements lose handlers, and multiple flow statements on one line lose the phase or module. A standalone MODULE in value/help-request flow can also call .push on an object and throw.

Split flow statements outside quoted text, expand chains while retaining source lines, preserve each request module's field association and distinguish ON CHAIN-INPUT/ON CHAIN-REQUEST. Accept # in the short MESSAGE class while retaining existing default-class handling. Fixtures are synthetic.

Validation: seven focused regression cases pass; five fail against base 50186bd before these fixes. Fifteen neighboring MESSAGE/dynpro converter tests pass. Generated ABAP is checked by the converter's parser. Repository ABAP lint (2.120.73, unchanged abaplint.jsonc) reports zero issues across 1,229 files. An independent review found no remaining code blockers; its source-line finding is fixed and covered by a regression assertion. Full CI and application acceptance are not claimed.

Accept hash characters in short MESSAGE classes. Split flow statements at unquoted terminators, expand colon chains, retain request-module field associations and distinguish CHAIN conditions.

Seven focused converter/parser regressions pass; five reproduce failures on upstream main before the fix. Generated source passes the converter parser validation. SAP exports are not used by these tests.
@larshp

larshp commented Oct 21, 2026

Copy link
Copy Markdown
Member

thanks

hmm, not sure why the unit tests did not trigger, probably github having a bad day, I'll push some changes to main, then we can update this branch

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ larshp
❌ flujo-app
You have signed the CLA already but the status is still pending? Let us recheck it.

@larshp

larshp commented Oct 21, 2026

Copy link
Copy Markdown
Member

ah, sign the CLA, and dont [skip ci]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants