Repository navigation
Refactor page refinement validation to accept only current-page results - #622
Merged
Merged
Conversation
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Page refinement could reject a valid current-page result because a neighbour's initial or adopted structure disagreed with it. The citation-on reproduction failed when a continuation named a publication cue that the previous page had excluded.
This refactors acceptance to validate only the complete current-page result. Source decoding discards initial semantic decisions; cross-page assembly mechanically applies current-page append declarations using output cursors, preserving unbound content when no cursor exists. It removes neighbour membership checks, successor trial adoption, cross-page metadata gates, and post-repair rebinding. Batch and streaming paths share assembly. PCEX v6 storage is unchanged.
The repair prompt separates observations from initial proposals and leaves JEV scores at admission. Regression coverage includes forbidden-evidence reads, independent page jobs, internal-invalid results, unbound streams, and transactional delivery. Smoke expectations now use stable source IDs and check the four actual printed footnotes and their continuation instead of requiring an artificial fifth definition.
Validation:
Earlier paid trials exposed model classification errors and an obsolete definition-count assertion; those failed reports were retained. The final targeted run passed; this does not establish deterministic model accuracy.
Related to #616, #619, #620 and oomol/pdf-craft-service#314. Implements VGE issue 983.