Skip to content

Refactor page refinement validation to accept only current-page results - #622

Merged
Moskize91 merged 1 commit into
mainfrom
vge/issue-983
Nov 6, 2026
Merged

Moskize91 merged 1 commit into
mainfrom
vge/issue-983

Conversation

@Moskize91

Copy link
Copy Markdown
Contributor

Page refinement could reject a valid current-page result because a neighbour's initial or adopted structure disagreed with it. The citation-on reproduction failed when a continuation named a publication cue that the previous page had excluded.

This refactors acceptance to validate only the complete current-page result. Source decoding discards initial semantic decisions; cross-page assembly mechanically applies current-page append declarations using output cursors, preserving unbound content when no cursor exists. It removes neighbour membership checks, successor trial adoption, cross-page metadata gates, and post-repair rebinding. Batch and streaming paths share assembly. PCEX v6 storage is unchanged.

The repair prompt separates observations from initial proposals and leaves JEV scores at admission. Regression coverage includes forbidden-evidence reads, independent page jobs, internal-invalid results, unbound streams, and transactional delivery. Smoke expectations now use stable source IDs and check the four actual printed footnotes and their continuation instead of requiring an artificial fifth definition.

Validation:

  • Full suite: 1965 tests, OK, 6 skipped; independently repeated by the VGE reviewer.
  • Pyright: 0 errors/warnings; pylint: 10.00/10.
  • Offline replay of original citation-on replies and the six-page repair case passed.
  • Final paid citation_footnotes gate: automated_passed=true, failures=[], intact printed definitions and cross-page continuation, no body/note leakage, preserved formula pixels. Three-page source/output previews inspected.

Earlier paid trials exposed model classification errors and an obsolete definition-count assertion; those failed reports were retained. The final targeted run passed; this does not establish deterministic model accuracy.

Related to #616, #619, #620 and oomol/pdf-craft-service#314. Implements VGE issue 983.

@Moskize91
Moskize91 merged commit a796afd into main Nov 6, 2026
2 of 3 checks passed
@Moskize91
Moskize91 deleted the vge/issue-983 branch November 6, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant