fix(dogfood): --prebuilt runs meeting-summary with onion-llm from Maven Central - #2007
Merged
Merged
Conversation
…en Central What: - dogfood/run.sh --prebuilt no longer needs the locally published battery: without one it builds meeting-summary against onion-llm from Maven Central (the jar's version, or the latest release for a dev jar) - the default mode and CI are unchanged - dogfood/README.md says which mode uses which battery Why: the daily Sensor runs with a release jar and no sbt, so a quarter of the dogfood suite was never exercised outside CI (#2002). Co-Authored-By: Onion Evolution Loop <evolution-loop@onion-lang.org> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N283s4Zga5rxnxcuSmPHdh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dogfood/run.sh --prebuiltno longer needs a locally published battery: without one,meeting-summaryis built againstonion-llmfrom Maven Central (the jar's version, or the latest release for a dev jar;LLM_VERSIONoverrides).dogfood/README.mdsays which mode uses which battery.Why
The daily Sensor runs with a release jar and no sbt, so a quarter of the dogfood suite was never exercised outside CI. Closes #2002.
Notes for reviewers
dogfood/changes (shell script + README); the project'sonion.tomlis copied to a temp dir and edited there, never in the tree.Verification
dogfood/run.sh --prebuiltwith a freshsbt assemblyjar and no~/.ivy2/localbattery: 4/4 projects pass (meeting-summary uses onion-llm 0.138.0 from Maven Central).🤖 Generated with Claude Code
https://claude.ai/code/session_01N283s4Zga5rxnxcuSmPHdh
Generated by Claude Code