Skip to content

RFC 45-4: Use protocol to select output type for streaming - #8089

Merged
jp9000 merged 16 commits into
obsproject:masterfrom
tytan652:preferred_output
Mar 20, 2023
Merged

RFC 45-4: Use protocol to select output type for streaming#8089
jp9000 merged 16 commits into
obsproject:masterfrom
tytan652:preferred_output

Conversation

@tytan652

@tytan652 tytan652 commented Jan 19, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

This PR is about the RFC 45.

Depends on:

Make OBS Studio rely on the notion of protocol to select the output while starting streaming rather than only asking the services.

The output id provided by the service is considered as preferred.

Motivation and Context

Part of the implementation of the RFC 45.

How Has This Been Tested?

Only testing trying to stream SRT and RIST, need more testing

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 added kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. Seeking Testers Build artifacts on CI labels Jan 19, 2023
@tytan652 tytan652 mentioned this pull request Jan 19, 2023
Merged
6 tasks
@tytan652 tytan652 added this to the OBS Studio 29.1 milestone Jan 19, 2023
@tytan652 tytan652 mentioned this pull request Jan 19, 2023
Merged
6 tasks
@tytan652
tytan652 force-pushed the preferred_output branch 2 times, most recently from 51478b2 to 320f692 Compare January 27, 2023 11:42
@tytan652
tytan652 force-pushed the preferred_output branch 2 times, most recently from 86add66 to 478f38b Compare January 31, 2023 07:50
@tytan652
tytan652 force-pushed the preferred_output branch 4 times, most recently from b213fd3 to da5b37d Compare February 16, 2023 14:10
@tytan652
tytan652 force-pushed the preferred_output branch 4 times, most recently from 0668417 to 97a5d88 Compare February 24, 2023 20:48
@tytan652
tytan652 force-pushed the preferred_output branch 2 times, most recently from d682549 to 9afc772 Compare March 1, 2023 09:47
@tytan652

tytan652 commented Mar 12, 2023

Copy link
Copy Markdown
Collaborator Author

Remove prefix related changes as it was done in the RFC.

@tytan652
tytan652 force-pushed the preferred_output branch 7 times, most recently from d6df206 to 0788a20 Compare March 15, 2023 12:25
@tytan652
tytan652 force-pushed the preferred_output branch 5 times, most recently from 95ffa5c to c7842ed Compare March 18, 2023 23:05
tytan652 added 16 commits March 19, 2023 15:29
@tytan652
libobs,docs: Add protocol in Outputs API
201bcda
@tytan652
obs-outputs,obs-ffmpeg: Add protocol to service outputs
855956f
@tytan652
rtmp-services: Add protocols to services JSON
513c6bc 
If the server URL is not an RTMP(S) URL, the protocol field becomes
required.

The output field becomes required on non-RTMP(S) services to keep
backward compatibility.

Also skip service if the protocol is not available.
@tytan652
libobs,docs: Add protocol to Services API
813b3b2
@tytan652
libobs,docs: Add protocol enumeration functions
56411ed
@tytan652
rtmp-services: Add protocol getter to services
fa58a38
@tytan652
libobs,docs: Add supported codecs functions with output id
48dc6dd
@tytan652
UI: Refactor Qt slots in stream settings page
5a40934
@tytan652
UI: Use protocol to list compatible codecs
e00e271
@tytan652
rtmp-services: Remove fallback to H264 if no codec found
9d8d98b 
The fallback in now inside the output.
@tytan652
UI: Use protocol to enable network options
44ca002
@tytan652
UI: Remove hardcoded stream codec list
8d6cacc
@tytan652
obs-ffmpeg: Remove AV1 from SRT/RIST supported codecs
e317c88 
MPEG-TS standard is not ready for AV1
@tytan652
libobs,docs: Add preferred output type to Service API
1e0f4a6
@tytan652
rtmp-services: Remove output getter from rtmp_common
213eb61
@tytan652
UI: Select streaming output based on the protocol
ea28587
@jp9000
jp9000 merged commit ea28587 into obsproject:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

kind/enhancement Enhancements are not bugs or new features but can improve usability or performance. Seeking Testers Build artifacts on CI

Projects

None yet

Milestone

OBS Studio 29.1

Development

Successfully merging this pull request may close these issues.

2 participants

@tytan652 @jp9000