win-dshow: Set audio devices to OBS sample rate - #13867
Open
prgmitchell wants to merge 1 commit into
Open
Conversation
Pass the configured OBS sample rate to libdshowcapture when configuring DirectShow audio devices to prevent devices from silently using their default sample rates.
Contributor
|
Without this PR: with: Same result when using a custom audio source set to the same device. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pass the configured OBS sample rate to libdshowcapture when configuring DirectShow audio devices to prevent devices from silently using their default sample rates.
Depends on obsproject/libdshowcapture#33
Motivation and Context
Common issue in support, current requires a workaround of muting the dshow device and adding a separate audio input capture source to load the correct sample rate.
How Has This Been Tested?
Requires testing from others as I don't have a device with a default sample rate of 44.1khz.
Tested with a build sent to others though so I am marking the tested box in the checklist as complete
Types of changes
Checklist: