nv-filters: Enable support for newest SDK - #13838
Open
pkviet wants to merge 4 commits into
Open
Conversation
pkviet
force-pushed
the
nvidia_sdk_update
branch
4 times, most recently
from
August 30, 2026 19:10
ad44e6b to
f08c935
Compare
RytoEX
requested changes
Aug 31, 2026
RytoEX
left a comment
RytoEX
left a comment
Member
There was a problem hiding this comment.
If the comments I've marked in nvafx-load.h and nvvfx-load.h come from the SDK, then don't change them.
Commit message nits:
nv-filters :->nv-filters:- dll -> DLL
- nvafx -> NVAFX
What happens if a user has the current versions of AFX/VFK (1.6.1.2/0.7.6.0) installed?
|
|
||
| #define NVAFX_PARAM_NUM_INPUT_SAMPLES_PER_FRAME "num_input_samples_per_frame" | ||
| #define NVAFX_PARAM_NUM_OUTPUT_SAMPLES_PER_FRAME "num_output_samples_per_frame" | ||
| /* sdk >= 3.0.0.49, replaces the 2 previous define... */ |
Member
There was a problem hiding this comment.
Suggested change
| /* sdk >= 3.0.0.49, replaces the 2 previous define... */ | |
| /* SDK >= 3.0.0.49: replaces the 2 previous define... */ |
| #define NVAFX_PARAM_NUM_OUTPUT_CHANNELS "num_output_channels" | ||
| #define NVAFX_PARAM_INTENSITY_RATIO "intensity_ratio" | ||
| #define NVAFX_PARAM_ENABLE_VAD "enable_vad" | ||
| /** sdk >= 3.0.0.49 : Voice activity status (boolean). This is immutable parameter */ |
Member
There was a problem hiding this comment.
Suggested change
| /** sdk >= 3.0.0.49 : Voice activity status (boolean). This is immutable parameter */ | |
| /** SDK >= 3.0.0.49: Voice activity status (boolean) is an immutable parameter. */ |
Member
There was a problem hiding this comment.
I don't see this change pushed. Was it omitted?
Member
Author
There was a problem hiding this comment.
Mmh I was sure I had pushed it. Initially I had forgotten to save the file but then i repushed. I'll fix tomorrow anyway
pkviet
force-pushed
the
nvidia_sdk_update
branch
4 times, most recently
from
September 4, 2026 07:40
61a8fe9 to
ea8c3a9
Compare
RytoEX
requested changes
Sep 4, 2026
RytoEX
left a comment
RytoEX
left a comment
Member
There was a problem hiding this comment.
Commit message nit still applies. Will set aside time to re-test this.
SDK 3.0.0 brings compatibility with arm64. The DLL loading sequence has been adjusted since the FX are now loaded in their own child DLL. The DLL loader has been also cleaned up by removing unused symbols. This allowed us to dodge a few ABI breaks from NVIDIA... Signed-off-by: pkv <pkv@obsproject.com>
Voice Activated Detection (VAD) does not work with the room echo removal (dereverb) FX. So we remove it from Properties. Signed-off-by: pkv <pkv@obsproject.com>
This updates the video FX SDK to 1.3.0, which enables arm64 support. Backwards compatibility with SDK 0.7.6 has been kept. Signed-off-by: pkv <pkv@obsproject.com>
CUDA is no longer used in Audio FX, so we remove everything related to it in the nvafx loader. Signed-off-by: pkv <pkv@obsproject.com>
pkviet
force-pushed
the
nvidia_sdk_update
branch
from
September 4, 2026 20:59
ea8c3a9 to
8ca13cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds support to :
These versions do not add any feature but allow compatibility with ARM64.
Due to some ABI breaks with v3.0.0, some clean-up of unused functions has also been done.
Unused CUDA functions have also been removed from the video FX loader.
The DLL loading has been updated because NVIDIA broke the DLL architecture by offloading the FX to child DLLs.
NB: there are issues when video and audio FX redist are not updated at the same time. This actually occurs at any update of both FX SDKs. NVIDIA can only ensure both are working when the versions are those released concurrently (private comm. to the PR author).
The core of the problem is that both SDKs rely on the same set of dlls (notably nvinfer) and if versions are mismatched, one of the 2 SDKs will not work.
NB2: I chose to explicitly load the child FX dlls we use instead of using AddDllDirectory. This allows an early failure in case of issues: the main dlls might load before having attempted to load their children FX dlls which are usually loaded only when an effect is created, which is much later in the pipeline.
Motivation and Context
Support ARM64 platform.
How Has This Been Tested?
Tested that:
Untested:
Types of changes
Checklist: