feat(dashboard): redesign the auth shell with a dithered brand panel - #446
Open
Rish-it wants to merge 5 commits into
Open
feat(dashboard): redesign the auth shell with a dithered brand panel#446Rish-it wants to merge 5 commits into
Rish-it wants to merge 5 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the dashboard’s auth-area UI by introducing a new split “brand panel + form” layout, including an optional GPU-driven ordered-dither effect for the brand image, and adjusts auth page typography to match the new proportions.
Changes:
- Adds a WebGL2-based ordered-dither renderer (
DitherImage) and integrates it intoAuthShell’s new brand-panel layout. - Refactors
AuthShellinto an optional<aside>brand panel + scrollable form column, with anasideopt-out for wide pages. - Updates auth page headings from
text-xltotext-[30px]with tighter leading/tracking across auth flows.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/dashboard/src/components/auth-shell.tsx | Adds WebGL2 dithered brand panel and refactors the auth shell layout with an aside opt-out. |
| apps/dashboard/src/app/mcp/authorize/page.tsx | Disables the brand panel for the wide consent screen via aside={false}. |
| apps/dashboard/src/app/(auth)/verify-email/page.tsx | Updates auth page headings to the new size/typography. |
| apps/dashboard/src/app/(auth)/select-organization/page.tsx | Updates auth page headings to the new size/typography. |
| apps/dashboard/src/app/(auth)/reset-password/page.tsx | Updates auth page headings to the new size/typography. |
| apps/dashboard/src/app/(auth)/register/page.tsx | Updates auth page headings to the new size/typography. |
| apps/dashboard/src/app/(auth)/login/page.tsx | Updates auth page headings to the new size/typography. |
| apps/dashboard/src/app/(auth)/forgot-password/page.tsx | Updates auth page headings to the new size/typography. |
Suppressed comments (2)
apps/dashboard/src/components/auth-shell.tsx:289
- If a VAO is created for WebGL2 rendering, it should be deleted during cleanup to avoid leaking GPU resources when navigating between auth pages.
resizeObserver.disconnect();
gl.deleteTexture(texture);
gl.deleteProgram(program);
apps/dashboard/src/components/auth-shell.tsx:232
- In WebGL2 you must have a Vertex Array Object bound before calling
drawArrays, even if the vertex shader only usesgl_VertexIDand there are no attributes. Without a bound VAO,gl.drawArrayswill raise INVALID_OPERATION and nothing will render.
const texture = gl.createTexture();
if (!texture) {
gl.deleteProgram(program);
return;
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+213
to
+217
| const gl = canvas?.getContext("webgl2", { | ||
| alpha: false, | ||
| antialias: false, | ||
| powerPreference: "high-performance", | ||
| }); |
| <DitherImage src={ASIDE_IMAGE} /> | ||
| <div className="absolute inset-0 bg-gradient-to-t from-black/80 via-transparent to-black/10" /> | ||
| <div className="absolute start-6 top-6 flex items-center gap-2.5 lg:start-10 lg:top-9"> | ||
| <Logo size={24} className="border-white!" /> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Redesigns the auth pages (login, register, forgot/reset password, verify email, select-organization) with a split layout: a brand panel with a GPU ordered-dither effect beside the form on desktop, collapsing to a top bar on mobile.
Motivation
Refreshes the auth experience to match the current landing/marketing visual direction.
Related issue
None
Changes
DitherImage) toauth-shell.tsx, driven by a fullscreen-triangle shader with animated FBM noise, falls back silently to the static<Image>when WebGL2 or shader compilation is unavailableAuthShellinto a brand<aside>panel + form column onlg:breakpoints, with anasideprop to opt individual pages out (used bymcp/authorize, which is too wide to share the viewport)text-xltotext-[30px]across all six auth pages for the new layout's proportionsVerification
Manually exercised login, register, forgot-password, reset-password, verify-email, select-organization, and mcp/authorize at mobile and desktop widths, both themes, and with
prefers-reduced-motionon/off.Screenshots
Not captured in this pass — happy to add before merge if wanted.
Checklist