Skip to content

balloon: PAGE_POISON feature description is inconsistent #240

Description

@mstsirkin

The short description of VIRTIO_BALLOON_F_PAGE_POISON in the feature bits section says:

A hint to the device, that the driver will immediately write poison_val to pages after deflating them.

This is inconsistent with the actual normative requirements in two ways:

  1. Only mentions deflation: The feature also governs page reporting behavior. The driver MUST initialize reported pages with poison_val before reporting them (Free Page Reporting driver normative), and the device MUST NOT modify reported pages to a value other than poison_val (Free Page Reporting device normative). The short description omits this.

  2. Calls it a "hint": The driver normative has MUST statements ("The driver MUST initialize the deflated pages with poison_val"), so this is not merely a hint -- it is a binding requirement.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions