nix_flake_fmt: drop legacy codepath, fix timeouts - #350
Conversation
nix 2.29 was released over a year ago on May 2025: <https://discourse.nixos.org/t/nix-2-29-0-released/64609> There's entirely too much code here, let's get rid of it!
mightyiam
left a comment
There was a problem hiding this comment.
Okay, I'm not familiar with the API. Assuming you're right about _done(nil) this looks good to me and am looking forward to using it.
Previously we were returning false, which was useless: we're in an async process and need to call `_done`, otherwise the user just experiences weird timeouts. Reported in <nvimtools#349>
9ec7913 to
7f90c2e
Compare
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |

What does this PR do?
Two things here, I suggest reading the commits independently:
Checklist
understand it should be contributed to
nvimtools/none-ls-extras.nvim
instead