Skip to content

nix_flake_fmt: drop legacy codepath, fix timeouts - #350

Merged
mochaaP merged 3 commits into
nvimtools:mainfrom
jfly:nix_flake_fmt-fixes
Aug 10, 2026
Merged

nix_flake_fmt: drop legacy codepath, fix timeouts#350
mochaaP merged 3 commits into
nvimtools:mainfrom
jfly:nix_flake_fmt-fixes

Conversation

@jfly

@jfly jfly commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do?

Two things here, I suggest reading the commits independently:

  1. Drop the legacy nix codepath
  2. Fix a timeout that happens when the flake doesn't define a formatter. Reported in Smarter nix_flake_fmt condition? #349

Checklist

  • If I'm adding a new builtin (linter, formatter, code action, etc.), I
    understand it should be contributed to
    nvimtools/none-ls-extras.nvim
    instead
  • I've written tests for these changes

nix 2.29 was released over a year ago on May 2025:
<https://discourse.nixos.org/t/nix-2-29-0-released/64609>

There's entirely too much code here, let's get rid of it!
@nvimtools nvimtools deleted a comment from coderabbitai Bot Aug 9, 2026

@mightyiam mightyiam left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'm not familiar with the API. Assuming you're right about _done(nil) this looks good to me and am looking forward to using it.

Comment thread lua/null-ls/builtins/formatting/nix_flake_fmt.lua Outdated
jfly added 2 commits August 10, 2026 08:46
Previously we were returning false, which was useless: we're in an async
process and need to call `_done`, otherwise the user just experiences
weird timeouts.

Reported in <nvimtools#349>
@jfly
jfly force-pushed the nix_flake_fmt-fixes branch from 9ec7913 to 7f90c2e Compare August 10, 2026 15:46
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aa5655de-e432-4f9c-a447-dede23876cca

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mochaaP
mochaaP merged commit c4b82bb into nvimtools:main Aug 10, 2026
4 checks passed
@mochaaP

mochaaP commented Aug 10, 2026

Copy link
Copy Markdown
Member
image

@jfly
jfly deleted the nix_flake_fmt-fixes branch August 10, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants