Skip to content

fix: pin metadata hook dependencies - #16

Merged
jjomier merged 1 commit into
mainfrom
fix/pin-precommit-dependencies
Oct 26, 2026
Merged

jjomier merged 1 commit into
mainfrom
fix/pin-precommit-dependencies

Conversation

@jjomier

@jjomier jjomier commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores
    • Updated metadata validation tooling to use fixed versions, making its checks consistent across environments.
    • This maintenance update does not change app features, behavior, or the experience available to end users.

@jjomier
jjomier requested a review from bhashemian October 26, 2026 13:14
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 4968f962-19a3-4637-bfeb-4e9fbd69d220
Commits

Reviewing files that changed from the base of the PR and between 29a1fed and 5a4cdc6.

Files selected for processing: 1
  • .pre-commit-config.yaml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The metadata validation hook now pins jsonschema to 4.23.0 and referencing to 0.36.2.

Changes

Metadata validation

Layer / File(s) Summary
Pin hook dependencies
.pre-commit-config.yaml
The hook now uses exact versions for jsonschema and referencing instead of version ranges.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: Minimal · up to 5a4cd

The dependency pins do not introduce an established hook setup or metadata-validation failure.

Pre-merge checks: Passed 4
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "fix: pin metadata hook dependencies" matches the only change in the changeset. The pre-commit config now pins jsonschema to 4.23.0 and referencing to 0.36.2 for the holoscan-metadata-valida…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "fix: pin metadata hook dependencies" matches the only change in the changeset. The pre-commit config now pins jsonschema to 4.23.0 and referencing to 0.36.2 for the holoscan-metadata-validate hook, instead of allowing version ranges. The PR objectives also state the goal of pinning metadata hook dependencies. The title is short, specific, and states the main change.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@jjomier
jjomier merged commit 24aaaab into main Oct 26, 2026
1 of 2 checks passed
@jjomier
jjomier deleted the fix/pin-precommit-dependencies branch October 26, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants