Skip to content

feat: end to end wiring for per message nack#365

Draft
ayildirim21 wants to merge 4 commits into
numaproj:mainfrom
ayildirim21:per-msg-nack
Draft

feat: end to end wiring for per message nack#365
ayildirim21 wants to merge 4 commits into
numaproj:mainfrom
ayildirim21:per-msg-nack

Conversation

@ayildirim21

@ayildirim21 ayildirim21 commented Jul 1, 2026

Copy link
Copy Markdown
Member

Closes #348

Signed-off-by: Abdullah Yildirim <a3hadi@protonmail.com>
@ayildirim21 ayildirim21 marked this pull request as draft July 1, 2026 15:52
Signed-off-by: Abdullah Yildirim <a3hadi@protonmail.com>
Signed-off-by: Abdullah Yildirim <a3hadi@protonmail.com>
Signed-off-by: Abdullah Yildirim <a3hadi@protonmail.com>
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.79798% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.36%. Comparing base (030ded1) to head (ada254d).

Files with missing lines Patch % Lines
packages/pynumaflow/pynumaflow/_nack.py 75.00% 3 Missing and 1 partial ⚠️
...kages/pynumaflow/pynumaflow/batchmapper/_dtypes.py 75.00% 3 Missing ⚠️
packages/pynumaflow/pynumaflow/mapper/_dtypes.py 75.00% 3 Missing ⚠️
...kages/pynumaflow/pynumaflow/mapstreamer/_dtypes.py 75.00% 3 Missing ⚠️
...pynumaflow/pynumaflow/sourcetransformer/_dtypes.py 75.00% 3 Missing ⚠️
...ges/pynumaflow/pynumaflow/sinker/servicer/utils.py 33.33% 1 Missing and 1 partial ⚠️
packages/pynumaflow/pynumaflow/sinker/_dtypes.py 85.71% 1 Missing ⚠️
packages/pynumaflow/pynumaflow/sourcer/_dtypes.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
- Coverage   92.74%   92.36%   -0.38%     
==========================================
  Files          67       68       +1     
  Lines        3540     3630      +90     
  Branches      232      234       +2     
==========================================
+ Hits         3283     3353      +70     
- Misses        191      209      +18     
- Partials       66       68       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Per-Message Nack Support for Python SDK

1 participant