buffer: implement blob.textStream()#64036
Open
KhafraDev wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: Matthew Aitken <maitken033380023@gmail.com>
KhafraDev
force-pushed
the
blob-textstream
branch
from
4b51988 to
e88dec3
Compare
Renegade334
added
semver-minor
Renegade334
approved these changes
Jun 21, 2026
|
|
||
| Returns a new `ReadableStream` that allows the content of the `Blob` to be read | ||
| as a stream of UTF-8 decoded strings. It is equivalent to piping | ||
| [`blob.stream()`][] through a [`TextDecoderStream`][] set up with UTF-8. |
Member
There was a problem hiding this comment.
Nit: "set up with" matches the spec operation, but sounds a bit unnatural here.
Suggested change
| [`blob.stream()`][] through a [`TextDecoderStream`][] set up with UTF-8. | |
| [`blob.stream()`][] through a UTF-8 [`TextDecoderStream`][]. |
Member
Author
There was a problem hiding this comment.
the one time the CI passes first time...
mcollina
approved these changes
Jun 21, 2026
mcollina
left a comment
mcollina
left a comment
Member
There was a problem hiding this comment.
LGTM
I'm good with the implementation, but I think it might be possible to optimize this a lot by avoiding one stream. I'm not sure we should be doing this right now.
github-actions
Bot
removed
the
request-ci
Collaborator
aduh95
added
author ready
gurgunday
approved these changes
Jun 21, 2026
lpinca
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements Blob.prototype.textStream()
refs: w3c/FileAPI@cd1d1da
refs: nodejs/undici@0d6ecc5