Skip to content

src: bump NODE_MAJOR_VERSION to 27#63128

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
RafaelGSS:fix-node-semver-major
May 5, 2026
Merged

src: bump NODE_MAJOR_VERSION to 27#63128
aduh95 merged 1 commit into
nodejs:mainfrom
RafaelGSS:fix-node-semver-major

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

It seems the git node release script
didn't handle that for semver-major

cc: @nodejs/releasers @aduh95

@RafaelGSS RafaelGSS added the fast-track PRs that do not need to wait for 72 hours to land. label May 5, 2026
@github-actions

github-actions Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @RafaelGSS. Please 👍 to approve.

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label May 5, 2026
@RafaelGSS RafaelGSS added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. labels May 5, 2026
@RafaelGSS

Copy link
Copy Markdown
Member Author

I have to rebase once #63127 lands

It seems the `git node release` script
didn't handle that for semver-major

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS force-pushed the fix-node-semver-major branch from 00786c3 to 3eb4859 Compare May 5, 2026 16:19
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels May 5, 2026
@codecov

codecov Bot commented May 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (6df4f7b) to head (3eb4859).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63128      +/-   ##
==========================================
+ Coverage   89.67%   89.69%   +0.01%     
==========================================
  Files         712      712              
  Lines      221251   221251              
  Branches    42391    42391              
==========================================
+ Hits       198405   198447      +42     
+ Misses      14669    14644      -25     
+ Partials     8177     8160      -17     

see 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 merged commit 18f938d into nodejs:main May 5, 2026
34 of 35 checks passed
@aduh95

aduh95 commented May 5, 2026

Copy link
Copy Markdown
Contributor

Landed in 18f938d

araujogui pushed a commit to araujogui/node that referenced this pull request May 26, 2026
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: nodejs#63128
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v26.x PRs that should not land on the v26.x-staging branch and should not be released in v26.x. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants