fs: prevent spurious recursive watch events on prefix siblings#63095
Merged
Conversation
nodejs-github-bot
added
fs
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63095 +/- ##
========================================
Coverage 90.33% 90.33%
========================================
Files 730 730
Lines 234205 234365 +160
Branches 43927 43927
========================================
+ Hits 211559 211714 +155
+ Misses 14370 14368 -2
- Partials 8276 8283 +7
🚀 New features to boost your workflow:
|
ShogunPanda
approved these changes
May 5, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
marcopiraccini
added a commit
to marcopiraccini/node
that referenced
this pull request
May 23, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
marcopiraccini
force-pushed
the
rename-watch-fix
branch
from
0e5482e to
430d3a4
Compare
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 716a92e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in the JS-based recursive
fs.watch(used on Linux) where deleting an entry caused spuriousrenameevents to be emitted for unrelated sibling entries whose names share a prefix with the deleted entry.FSWatcher#unwatchFiles(file)inlib/internal/fs/recursive_watch.jsusedStringPrototypeStartsWith(filename, file)to find the watched entries to remove. This match is a raw string prefix, so deletingfooalso unwatchedfoo_,foo_bar,foo_bar/file.txt, and so on. The next time#watchFolderwalked the parent directory, those still-on-disk siblings were missing from#filesand were treated as newly created, firing extrarenameevents and re-attaching watchers redundantly.Fix
Match by exact path, or by
deletedPath + path.sepprefix, so only the deleted entry and its actual descendants are unwatched.Fixes: #58868