Skip to content

docs(asynchronous-work): fix misaligned event loop ASCII diagram and add warning for changes to diagram alignment#78

Open
oceansync wants to merge 1 commit into
nodejs:mainfrom
oceansync:docs/event-loop-diagram-alignment
Open

docs(asynchronous-work): fix misaligned event loop ASCII diagram and add warning for changes to diagram alignment#78
oceansync wants to merge 1 commit into
nodejs:mainfrom
oceansync:docs/event-loop-diagram-alignment

Conversation

@oceansync
Copy link
Copy Markdown

Summary

This PR adjusts the event loop ASCII diagram in the markdown source so its spacing and alignment render correctly on the live docs page.

Changes

  • update the ASCII diagram in pages/asynchronous-work/event-loop-timers-and-nexttick.md to reflect proper alignment
  • add a contributor note explaining that the raw markdown may look slightly off while still rendering correctly in the generated HTML

Why

The event loop diagram is whitespace-sensitive, and small formatting changes can make it look misaligned in source or in the rendered page. This change preserves the intended layout and documents that behavior for future contributors. Without this note, there is a risk that well-intentioned contributors might attempt to "fix" the alignment in the .md file, which would actually break the visual layout for end-users.

This note serves as a safeguard to preserve the correct live rendering.

Verification

  • reviewed the markdown source formatting
  • verified the generated HTML renders the diagram correctly

Current View:

image

Fixed View:

image

…add note about future changes to check live page preview

Fix the misaligned diagram spacing and alignment of components.
Add a HTML comment to the event loop phase diagram to clarify that
the source alignment is intentional for correct HTML rendering.
This prevents accidental misalignment by future contributors.
@vercel
Copy link
Copy Markdown

vercel Bot commented May 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Ready Ready Preview May 26, 2026 11:28pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 26, 2026

PR Summary

Low Risk
Documentation-only whitespace and comment changes with no runtime or API impact.

Overview
Event loop docs: Realigns the ASCII diagram in event-loop-timers-and-nexttick.md so it displays correctly on the published HTML page (whitespace-sensitive layout).

Adds an HTML comment above the diagram telling contributors the raw markdown may look off while still rendering correctly live, and to avoid “fixing” alignment in source unless the live page is actually broken.

Reviewed by Cursor Bugbot for commit 5f8dba7. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/timers

Please review the changes when you have a chance. Thank you! 🙏

@mikeesto
Copy link
Copy Markdown
Member

What browser? This looks broken for me in Chrome

Screenshot 2026-05-27 at 10 06 24 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants